feat(codepipeline): change default pipeline type to V2 (under feature flag) #29096

go-to-k · 2024-02-14T05:06:44Z

Reason for this change

We discussed about the default pipeline type, it was concluded that the new type (V2) should be the default.

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts#L492

Description of changes

Change the default value using a feature flag so as not to affect existing processing.

Description of how you validated changes

Bot unit and integ tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…r feature flag)

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

go-to-k · 2024-02-14T06:50:08Z

...testing/framework-integ/test/aws-codepipeline-actions/test/cloudformation/integ.stacksets.ts

+const app = new App({
+  postCliContext: {
+    '@aws-cdk/aws-codepipeline:defaultPipelineTypeToV2': false,
+  },
+});


If this is not specified, CodeBuild CI will error.

@aws-cdk-testing/framework-integ: CHANGED pipelines/test/integ.pipeline 1.467s @aws-cdk-testing/framework-integ: Resources @aws-cdk-testing/framework-integ: [~] AWS::CodePipeline::Pipeline Pipeline9850B417 @aws-cdk-testing/framework-integ: 笏披楳 [+] PipelineType @aws-cdk-testing/framework-integ: 笏披楳 V2 @aws-cdk-testing/framework-integ: Snapshot Results: @aws-cdk-testing/framework-integ: Tests: 41 failed, 801 total @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/cloudformation/integ.stacksets.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.cfn-template-from-repo.lit.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.lambda-deployed-through-codepipeline.lit.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.lambda-pipeline.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-alexa-deploy.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-cfn-cross-region.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-cfn-with-action-role.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-cfn.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-build-batch.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-build-multiple-inputs-outputs.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-commit-build.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-commit-custom-event.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-commit-main.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-commit.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-deploy-ecs.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-code-deploy.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecr-source.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-ecs-deploy.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-elastic-beanstalk-deploy.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-events.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-jenkins.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-manual-approval.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-s3-deploy.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-stepfunctions.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/integ.pipeline-with-replication.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-codepipeline-actions/test/s3/integ.source-bucket-events-cross-stack-same-env.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-events-targets/test/codepipeline/integ.pipeline-event-target.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.newpipeline-with-codebuild-logging.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.newpipeline-with-cross-account-keys.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.newpipeline-with-cross-region-replication-buckets.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.newpipeline-with-file-system-locations.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.newpipeline-with-vpc.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.newpipeline.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-security.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-artifact-bucket.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-assets-single-upload.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-assets.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-stack-outputs-in-custom-step.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-variables.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-without-prepare.js @aws-cdk-testing/framework-integ: Failed: /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline.js @aws-cdk-testing/framework-integ: Error: Some tests failed! @aws-cdk-testing/framework-integ: To re-run failed tests run: integ-runner --update-on-failed @aws-cdk-testing/framework-integ: at main (/codebuild/output/src3346000757/src/github.com/aws/aws-cdk/packages/@aws-cdk/integ-runner/lib/cli.js:191:19) @aws-cdk-testing/framework-integ: Error: integ-runner exited with error code 1 @aws-cdk-testing/framework-integ: Tests failed. Total time (2m5.3s) | integ-runner (1m49.2s) | /codebuild/output/src3346000757/src/github.com/aws/aws-cdk/node_modules/jest/bin/jest.js (14.2s) @aws-cdk-testing/framework-integ: !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

I'm a bit confused why we need to set the feature flag to false in context. Wouldn't this check be false when no context is provided and doesn't change the integ test behaviour?

const isDefaultV2 = FeatureFlags.of(this).isEnabled(cxapi.CODEPIPELINE_DEFAULT_PIPELINE_TYPE_TO_V2);

I am confused too, but I actually got the error in the CodeBuild CI. I thought there was no difference in the local environment...
I'm willing to take time somewhere to investigate.

As expected, it appears that if this change is not made, there will be a difference. However, the difference does not occur in my local environment (using the integ runner). I guess that perhaps the CodeBuild settings running in CI Workflow (or build.sh) are different.

79cd494

@aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/cloudformation/integ.stacksets 2.077s @aws-cdk-testing/framework-integ: Resources @aws-cdk-testing/framework-integ: [~] AWS::CodePipeline::Pipeline PipelineC660917D @aws-cdk-testing/framework-integ: 笏披楳 [+] PipelineType @aws-cdk-testing/framework-integ: 笏披楳 V2

Build log

jumic

Should we explain the feature flag in the CodePipeline README? I think that would be useful. Otherwise it looks good from my point of view. 👍

go-to-k · 2024-03-03T09:47:46Z

@jumic

Thank you for the review.

I added the doc for the feature flag in REAME. Could you please take a look at it?

jumic

Thanks. LGTM!

…peline-pipeline-type-default-v2

GavinZZ

Thanks for working on this! Left some questions and feedback.

packages/aws-cdk-lib/aws-codepipeline/README.md

GavinZZ · 2024-03-11T20:23:59Z

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts

@@ -549,7 +550,7 @@ export class Pipeline extends PipelineBase {
      disableInboundStageTransitions: Lazy.any({ produce: () => this.renderDisabledTransitions() }, { omitEmptyArray: true }),
      roleArn: this.role.roleArn,
      restartExecutionOnUpdate: props && props.restartExecutionOnUpdate,
-      pipelineType: props.pipelineType,
+      pipelineType: props.pipelineType ?? (isDefaultV2 ? PipelineType.V2 : undefined),


nit: seems redundant check since on line 536, you've already used null coalescing operator ??.

The line 536 is the following:

this.pipelineType = props.pipelineType ?? (isDefaultV2 ? PipelineType.V2 : PipelineType.V1);

The difference between the line 536 and the code is whether it sets undefined or PipelineType.V1 when props.pipelineType is undefined and the isDefaultV2 is false.

Without this code (not this.pipelineType), if someone who did not originally specify props.pipelineType upgrades to the version that includes this change, the PipelineType.V1 will be explicitly set to L1 if the feature flag is left off. This is by no means a breaking change, but it does mean that the version upgrade will cause the snapshot test to fail. In order to avoid changing the behavior with previous versions, it was intended that the template would be the same as the existing one.

Ahh thanks for the explanation.

GavinZZ · 2024-03-11T20:25:55Z

packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-variables.ts

@@ -51,8 +51,9 @@ class PipelineStack extends Stack {
 }

 const app = new App({
-  context: {
+  postCliContext: {


I'm not actually aware of the difference between context vs postCliContext. Can you explain why to use postCliContext here?

I did this because it didn't work with the actual context. I would like to investigate this as well.

I've tried putting it back in and some seem to succeed and others fail.

PS) Extracted tests where differences occurred in context.

@aws-cdk/aws-appconfig-alpha: CHANGED integ.configuration 2.097s @aws-cdk-testing/framework-integ: CHANGED aws-appconfig/test/integ.configuration 3.625s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/cloudformation/integ.stacksets 1.281s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.lambda-deployed-through-codepipeline.lit 2.179s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-ecr-source 0.986s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.cfn-template-from-repo.lit 3.579s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-alexa-deploy 3.408s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.lambda-pipeline 3.984s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-cfn-cross-region 3.705s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-cfn-with-action-role 3.668s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-code-build-batch 3.765s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-code-build-multiple-inputs-outputs 3.833s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-cfn 4.065s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-ecs-deploy 2.863s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-code-deploy-ecs 3.987s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-code-commit-build 4.418s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-events 2.853s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-jenkins 2.594s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/s3/integ.source-bucket-events-cross-stack-same-env 1.591s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-with-replication 1.803s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-stepfunctions 2.689s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-elastic-beanstalk-deploy 5.364s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-code-deploy 9.396s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-s3-deploy 9.515s @aws-cdk-testing/framework-integ: CHANGED aws-codepipeline-actions/test/integ.pipeline-manual-approval 11.714s @aws-cdk-testing/framework-integ: CHANGED aws-events-targets/test/codepipeline/integ.pipeline-event-target 2.799s @aws-cdk-testing/framework-integ: CHANGED pipelines/test/integ.pipeline-with-assets-single-upload 1.59s @aws-cdk-testing/framework-integ: CHANGED pipelines/test/integ.pipeline-with-assets 1.703s @aws-cdk-testing/framework-integ: CHANGED pipelines/test/integ.pipeline-security 2.06s @aws-cdk-testing/framework-integ: CHANGED pipelines/test/integ.pipeline 1.397s

@GavinZZ

Thanks for your merge.
I did a little research and it seems that the following line does not cause a difference even in context.

/// !cdk-integ VariablePipelineStack pragma:set-context:@aws-cdk/core:newStyleStackSynthesis=true

https://github.com/go-to-k/aws-cdk/blob/00e8a7b877a732b4236227f6462bf3914ce7a214/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-with-variables.ts#L2

However, using DefaultStackSynthesizer in the stack definition seems to cause a difference due to feature flags even if the above line is present.

const stack = new TestCdkStack(app, 'PipelineSecurityStack', { synthesizer: new DefaultStackSynthesizer(), });

https://github.com/go-to-k/aws-cdk/blob/00e8a7b877a732b4236227f6462bf3914ce7a214/packages/@aws-cdk-testing/framework-integ/test/pipelines/test/integ.pipeline-security.ts#L107

I am not sure because I have not read the source code thoroughly...

Regarding "context vs postCliContext", it seems that the postCliContext has priority over the context (and perhaps CLI contexts), environments, etc.

https://github.com/go-to-k/aws-cdk/blob/00e8a7b877a732b4236227f6462bf3914ce7a214/packages/aws-cdk-lib/core/lib/app.ts#L175

https://github.com/go-to-k/aws-cdk/blob/00e8a7b877a732b4236227f6462bf3914ce7a214/packages/aws-cdk-lib/core/lib/app.ts#L201-L221

This reverts commit 79cd494.

This reverts commit 8ad99f0.

This reverts commit 85f008e.

This reverts commit ce29920.

go-to-k · 2024-03-12T17:01:03Z

@GavinZZ Thanks for your review. I commented to your comments. Could you please check them?

mergify · 2024-03-12T18:17:17Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-03-12T18:45:10Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: b55237b
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-03-12T18:46:59Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

feat(codepipeline): change default value for pipelineType to V2 (unde…

f579c37

…r feature flag)

github-actions bot added the p2 label Feb 14, 2024

aws-cdk-automation requested a review from a team February 14, 2024 05:06

github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Feb 14, 2024

aws-cdk-automation previously requested changes Feb 14, 2024

View reviewed changes

integ test

fed918e

go-to-k marked this pull request as ready for review February 14, 2024 05:22

go-to-k changed the title ~~feat(codepipeline): change default value for pipelineType to V2 (under feature flag)~~ feat(codepipeline): change default value for pipelineType to V2 (under feature flag) Feb 14, 2024

go-to-k changed the title ~~feat(codepipeline): change default value for pipelineType to V2 (under feature flag)~~ feat(codepipeline): change default pipeline type to V2 (under feature flag) Feb 14, 2024

go-to-k added 2 commits February 14, 2024 14:47

change existing integ tests

aeca2c8

postCliContext

96dbaad

go-to-k commented Feb 14, 2024

View reviewed changes

go-to-k added 3 commits February 14, 2024 16:20

add to change rest integ tests

9c80945

appconfig integ

dc60a16

integ.codepipeline-start-pipeline-execution.ts

5e7e47b

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 14, 2024

Merge branch 'main' into codepipeline-pipeline-type-default-v2

1223806

github-actions bot mentioned this pull request Mar 1, 2024

Monthly PR metrics report - Feb 2023 #29328

Closed

jumic suggested changes Mar 1, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 1, 2024

README

a28c548

go-to-k requested a review from jumic March 3, 2024 09:47

jumic approved these changes Mar 3, 2024

View reviewed changes

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 3, 2024

go-to-k added 4 commits March 11, 2024 16:07

Merge branch 'main' of https://github.com/go-to-k/aws-cdk into codepi…

5a23e30

…peline-pipeline-type-default-v2

change unit tests

599243b

aws-appconfig/test/integ.configuration

3724ba6

integ.pipeline-type-v2-by-default

ae27b58

GavinZZ reviewed Mar 11, 2024

View reviewed changes

go-to-k added 9 commits March 12, 2024 20:43

README

aae1861

test for app context

79cd494

test postCliContext vs context

ce29920

Revert "test for app context"

31c5b13

This reverts commit 79cd494.

change postCliContext to context

85f008e

change postCliContext added newly to context

8ad99f0

Revert "change postCliContext added newly to context"

2621600

This reverts commit 8ad99f0.

Revert "change postCliContext to context"

6e0689d

This reverts commit 85f008e.

Revert "test postCliContext vs context"

0abe694

This reverts commit ce29920.

go-to-k requested a review from GavinZZ March 12, 2024 16:59

GavinZZ approved these changes Mar 12, 2024

View reviewed changes

Merge branch 'main' into codepipeline-pipeline-type-default-v2

b55237b

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Mar 12, 2024

mergify bot merged commit e85231c into aws:main Mar 12, 2024
12 checks passed

go-to-k deleted the codepipeline-pipeline-type-default-v2 branch March 13, 2024 01:41

This was referenced May 23, 2024

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#98

Open

[Snyk] Upgrade: , aws-cdk NOUIY/aws-solutions-constructs#99

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codepipeline): change default pipeline type to V2 (under feature flag) #29096

feat(codepipeline): change default pipeline type to V2 (under feature flag) #29096

go-to-k commented Feb 14, 2024 •

edited

Loading

aws-cdk-automation left a comment

go-to-k Feb 14, 2024

GavinZZ Mar 11, 2024

go-to-k Mar 12, 2024 •

edited

Loading

go-to-k Mar 12, 2024 •

edited

Loading

jumic left a comment

go-to-k commented Mar 3, 2024

jumic left a comment

GavinZZ left a comment

GavinZZ Mar 11, 2024

go-to-k Mar 12, 2024

GavinZZ Mar 12, 2024

GavinZZ Mar 11, 2024

go-to-k Mar 12, 2024

go-to-k Mar 12, 2024 •

edited

Loading

go-to-k Mar 13, 2024 •

edited

Loading

go-to-k commented Mar 12, 2024

mergify bot commented Mar 12, 2024

aws-cdk-automation commented Mar 12, 2024

mergify bot commented Mar 12, 2024

feat(codepipeline): change default pipeline type to V2 (under feature flag) #29096

feat(codepipeline): change default pipeline type to V2 (under feature flag) #29096

Conversation

go-to-k commented Feb 14, 2024 • edited Loading

Reason for this change

Description of changes

Description of how you validated changes

Checklist

aws-cdk-automation left a comment

Choose a reason for hiding this comment

go-to-k Feb 14, 2024

Choose a reason for hiding this comment

GavinZZ Mar 11, 2024

Choose a reason for hiding this comment

go-to-k Mar 12, 2024 • edited Loading

Choose a reason for hiding this comment

go-to-k Mar 12, 2024 • edited Loading

Choose a reason for hiding this comment

jumic left a comment

Choose a reason for hiding this comment

go-to-k commented Mar 3, 2024

jumic left a comment

Choose a reason for hiding this comment

GavinZZ left a comment

Choose a reason for hiding this comment

GavinZZ Mar 11, 2024

Choose a reason for hiding this comment

go-to-k Mar 12, 2024

Choose a reason for hiding this comment

GavinZZ Mar 12, 2024

Choose a reason for hiding this comment

GavinZZ Mar 11, 2024

Choose a reason for hiding this comment

go-to-k Mar 12, 2024

Choose a reason for hiding this comment

go-to-k Mar 12, 2024 • edited Loading

Choose a reason for hiding this comment

go-to-k Mar 13, 2024 • edited Loading

Choose a reason for hiding this comment

go-to-k commented Mar 12, 2024

mergify bot commented Mar 12, 2024

aws-cdk-automation commented Mar 12, 2024

AWS CodeBuild CI Report

mergify bot commented Mar 12, 2024

go-to-k commented Feb 14, 2024 •

edited

Loading

go-to-k Mar 12, 2024 •

edited

Loading

go-to-k Mar 12, 2024 •

edited

Loading

go-to-k Mar 12, 2024 •

edited

Loading

go-to-k Mar 13, 2024 •

edited

Loading