Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs-patterns): healthCheck property for ApplicationLoadBalancedFargateService #28797

Conversation

Nikola-Milovic
Copy link
Contributor

@Nikola-Milovic Nikola-Milovic commented Jan 21, 2024

Closes #28796

Like with other aws-ecs-pattern high level constructs, some properties aren't exposed. For aws_ecs_patterns.ApplicationLoadBalancedFargateService this is healthCheck property of the container.

There are already similar PRs #18219 for other constructs in the aws_ecs_patterns lib

Note:

I didn't add any test cases since ApplicationLoadBalancedFargateService does not seem to have them like the others do. I can maybe come back with another PR to add the test cases.

I didn't update the docs since it's a minor addition. And there is already an example for the QueueProcessingFargateService that uses the healthCheck, it might be redundant to add the same code example with different constructor name.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 21, 2024 08:43
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 labels Jan 21, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@Nikola-Milovic Nikola-Milovic changed the title feat(aws-ecs-patterns): add healthCheck property to ApplicationLoadBalancedFargateService feat(ecs-patterns): add healthCheck property to ApplicationLoadBalancedFargateService Jan 21, 2024
@Nikola-Milovic
Copy link
Contributor Author

Nikola-Milovic commented Jan 21, 2024

Exemption Request (not sure how to use this)

❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

I think I stated the reasons for not including these in the PR description, if someone from the AWS team can confirm that this is okay. If not I can push the updates to this PR, or one of the maintainers can

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jan 21, 2024
@aaythapa
Copy link
Contributor

aaythapa commented Jan 23, 2024

Hi @Nikola-Milovic, thank you for your contribution! For every new feature we require integration tests, README changes and unit tests. You can find other ApplicationLoadBalancedFargateService unit tests here and integration tests here.

@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Jan 23, 2024
@Nikola-Milovic
Copy link
Contributor Author

Nikola-Milovic commented Jan 24, 2024

@aaythapa Thanks for the links! I managed to navigate my way around the repo and figure out the tests.

EDIT: Seems that the current test won't deploy properly and is stuck in redeploy loop, will look into it and fix it!

@aws-cdk-automation aws-cdk-automation dismissed their stale review January 25, 2024 07:04

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aaythapa aaythapa changed the title feat(ecs-patterns): add healthCheck property to ApplicationLoadBalancedFargateService feat(ecs-patterns): healthCheck property to ApplicationLoadBalancedFargateService Feb 1, 2024
@aaythapa aaythapa changed the title feat(ecs-patterns): healthCheck property to ApplicationLoadBalancedFargateService feat(ecs-patterns): healthCheck property for ApplicationLoadBalancedFargateService Feb 1, 2024
aaythapa
aaythapa previously approved these changes Feb 6, 2024
Copy link
Contributor

@aaythapa aaythapa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@mergify mergify bot dismissed aaythapa’s stale review February 6, 2024 19:51

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 6, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8a00212
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Feb 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5996856 into aws:main Feb 6, 2024
16 checks passed
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
…edFargateService` (#28797)

Closes #28796

Like with other `aws-ecs-pattern` high level constructs, some properties aren't exposed. For `aws_ecs_patterns`.`ApplicationLoadBalancedFargateService` this is `healthCheck` property of the container. 

There are already similar PRs #18219 for other constructs in the `aws_ecs_patterns` lib

*Note*:

I didn't add any test cases since `ApplicationLoadBalancedFargateService` does not seem to have them like the others do. I can maybe come back with another PR to add the test cases.

I didn't update the docs since it's a minor addition. And there is already an example for the `QueueProcessingFargateService` that uses the `healthCheck`, it might be redundant to add the same code example with different constructor name. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
3 participants