Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CLI): nested stacks should be skipped by changeset diff #28784

Merged
merged 4 commits into from
Jan 22, 2024
Merged

chore(CLI): nested stacks should be skipped by changeset diff #28784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e23189c
fix
comcalvi Jan 19, 2024
6a1e96a
Merge branch 'main' of github.com:aws/aws-cdk into comcalvi/changeset…
comcalvi Jan 19, 2024
5b75579
fix
comcalvi Jan 19, 2024
3f027a4
Merge branch 'main' into comcalvi/changeset-again
mergify[bot] Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk/lib/api/util/cloudformation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ export async function createDiffChangeSet(options: PrepareChangeSetOptions): Pro
// eslint-disable-next-line no-console
debug('This stack contains one or more nested stacks, falling back to template-only diff...');

//return undefined;
return undefined;
}
}

Expand Down
1 change: 0 additions & 1 deletion packages/aws-cdk/test/diff.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,6 @@ Resources
const plainTextOutput = buffer.data.replace(/\x1B\[[0-?]*[ -/]*[@-~]/g, '')
.replace(/[ \t]+$/mg, '');
expect(plainTextOutput.trim()).toEqual(`Stack Parent
Could not create a change set, will base the diff on template differences (run again with -v to see the reason)
Resources
[~] AWS::CloudFormation::Stack AdditionChild
└─ [~] Resources
Expand Down
Loading