Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appconfig): deployment recreated on every cdk deployment #28782

Merged
merged 4 commits into from
Feb 13, 2024
Merged

fix(appconfig): deployment recreated on every cdk deployment #28782

merged 4 commits into from
Feb 13, 2024

Commits on Jan 19, 2024

  1. fix: deployment recreated on every cdk deployment

    Every time I perform a CDK deployment, the logicalId hash of the
    deployment resource changes and causes the deployment resource to be
    deleted and recreated. I'm assuming it is because the configuration
    `content` is part of the hash creation and I am creating the content
    using `lazy` and at the time of the hash creation it is still a token.
    
    Looking at the [CloudFormation
    docs](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-appconfig-deployment.html)
    for the deployment resource, a change to _any_ property causes a
    replacement so I don't think we need to control the recreation logic
    ourselves, we should just let CloudFormation do the resource replacement
    for us.
    corymhall committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    035d237 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2024

  1. updates based on review

    corymhall committed Feb 1, 2024
    Configuration menu
    Copy the full SHA
    9e2d57d View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2024

  1. Configuration menu
    Copy the full SHA
    81c5579 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    019ca6f View commit details
    Browse the repository at this point in the history