feat(ecs-patterns): cooldown parameter to QueueProcessingServiceBaseProps #28730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
feature-request
paulhcsun
reviewed
Jan 16, 2024
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
kaizencc
requested changes
Jan 16, 2024
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Show resolved
Hide resolved
kaizencc
changed the title
kaizencc
requested changes
Jan 17, 2024
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kaizen Conroy <[email protected]>
Co-authored-by: Kaizen Conroy <[email protected]>
…g-service-base.ts Co-authored-by: Kaizen Conroy <[email protected]>
…g-service-base.ts Co-authored-by: Kaizen Conroy <[email protected]>
kaizencc
reviewed
Jan 18, 2024
packages/aws-cdk-lib/aws-ecs-patterns/lib/base/queue-processing-service-base.ts
Outdated
Show resolved
Hide resolved
…g-service-base.ts
kaizencc
reviewed
Jan 18, 2024
packages/aws-cdk-lib/aws-ecs-patterns/test/fargate/queue-processing-fargate-service.test.ts
Outdated
Show resolved
Hide resolved
…ssing-fargate-service.test.ts
kaizencc
approved these changes
Jan 18, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an optional
Cooldownparameter that allows users to define the grace period after a scaling activity. Default will beundefinedto maintain compatibility.Closes #8298.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license