Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ec2): max iops value for io2 EBS volume is wrong #28695

Merged
merged 4 commits into from
Jan 17, 2024
Merged

fix(ec2): max iops value for io2 EBS volume is wrong #28695

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e74302
fix(ec2): max iops value for io2 EBS volume is wrong
go-to-k Jan 12, 2024
d7062d4
urls
go-to-k Jan 12, 2024
8fa58c8
change unit test
go-to-k Jan 12, 2024
9bc797b
Merge branch 'main' into ebs-iops-io2-max
mergify[bot] Jan 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/aws-cdk-lib/aws-ec2/lib/volume.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,11 +691,11 @@ export class Volume extends VolumeBase {
);
}
// Enforce minimum & maximum IOPS:
// https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ec2-ebs-volume.html
// https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ec2-volume.html
const iopsRanges: { [key: string]: { Min: number, Max: number } } = {};
iopsRanges[EbsDeviceVolumeType.GENERAL_PURPOSE_SSD_GP3] = { Min: 3000, Max: 16000 };
iopsRanges[EbsDeviceVolumeType.PROVISIONED_IOPS_SSD] = { Min: 100, Max: 64000 };
iopsRanges[EbsDeviceVolumeType.PROVISIONED_IOPS_SSD_IO2] = { Min: 100, Max: 64000 };
iopsRanges[EbsDeviceVolumeType.PROVISIONED_IOPS_SSD_IO2] = { Min: 100, Max: 256000 };
const { Min, Max } = iopsRanges[volumeType];
if (props.iops < Min || props.iops > Max) {
throw new Error(`\`${volumeType}\` volumes iops must be between ${Min} and ${Max}.`);
Expand Down
Loading