chore(migrate): enable import of resources on apps created from cdk migrate

[TheRealAmazonKendra]

Apps generated from cdk migrate with resources that aren't already part of a stack will (soon) create a migrate.json file. This file contains the list of resources that should be imported upon creation of the new app.

If this file is present and the source is either localfile or the ARN environment matches the deployment environment, running cdk deploy will:

1. Create a new stack and import the resources listed in migrate.json.
2. Apply outputs and CDKMetadata through a normal deployment.

Note: localfile is a placeholder value so that we can run integration tests on this change. Once some of the other in-progress work is finished, this will be updated.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

[aws-cdk-automation]

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

[comcalvi]

can we swap the order of tryGetResources and performResourceMigration? performResourceMigration is called by the public function, so it should be above tryGetResources

[TheRealAmazonKendra]

Will do

[comcalvi]

what about the other stacks?

[TheRealAmazonKendra]

CDK migrate only creates one stack. It is not compatible with multiple stacks at this time.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

[kaizencc]

1. i want to check that you mean to remove migrate.json after consuming it.
2. why does this function "deserve" to remove this file? it seems like an unnecessary side effect of a function named tryMigrateResources. Is this the place to govern the lifecycle of that file?

This is a non-blocking comment. I don't have the full picture of migrate, just want to call attention to this and if there's no problem, then ignore.

[TheRealAmazonKendra]

The intent here was to make deployment after using cdk migrate to generate an app zero touch, or as close to it as possible. CDK migrate generates this file that contains all the import data needed. So, the attempt at an import is only made when this file is present. Since the import only needs to happen on the first deployment, it deletes it at the end so that future deployments are not of the import type.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 7623593
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).