Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): new CodeBuild lambda compute images #28630

Merged

Conversation

paavovaananen-cgi
Copy link
Contributor

Add new Lambda compute images for both aarch64 and x86_64 arhictectures:

  • aws/codebuild/amazonlinux-aarch64-lambda-standard:corretto21
  • aws/codebuild/amazonlinux-aarch64-lambda-standard:nodejs20
  • aws/codebuild/amazonlinux-aarch64-lambda-standard:python3.12

Reference:
https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html#lambda-compute-images
aws/aws-codebuild-docker-images#687


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jan 9, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 9, 2024 15:01
@github-actions github-actions bot added the p2 label Jan 9, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@paavovaananen-cgi
Copy link
Contributor Author

Exemption Request

Currently all related tests use only a single image (AMAZON_LINUX_2_NODE_18) and inclusion of these new ones shouldn't require additional testing.

Please let me know if any improvements to this PR could be made. Thanks.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Jan 9, 2024
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@skilbjo
Copy link
Contributor

skilbjo commented Feb 2, 2024

hi, I was going to do a PR to implement the new node version but I see @paavovaananen-cgi has got it (thank you!). since the PR is approved, when and who is going to merge it ?

@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Feb 2, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review February 2, 2024 19:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Feb 2, 2024
Copy link
Contributor

mergify bot commented Feb 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c98ee51
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 610fce1 into aws:main Feb 2, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Feb 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

SankyRed pushed a commit that referenced this pull request Feb 8, 2024
Add new Lambda compute images for both `aarch64` and `x86_64` arhictectures:

- `aws/codebuild/amazonlinux-aarch64-lambda-standard:corretto21`
- `aws/codebuild/amazonlinux-aarch64-lambda-standard:nodejs20`
- `aws/codebuild/amazonlinux-aarch64-lambda-standard:python3.12`

Reference:
https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html#lambda-compute-images
aws/aws-codebuild-docker-images#687

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TheRealAmazonKendra pushed a commit that referenced this pull request Feb 9, 2024
Add new Lambda compute images for both `aarch64` and `x86_64` arhictectures:

- `aws/codebuild/amazonlinux-aarch64-lambda-standard:corretto21`
- `aws/codebuild/amazonlinux-aarch64-lambda-standard:nodejs20`
- `aws/codebuild/amazonlinux-aarch64-lambda-standard:python3.12`

Reference:
https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html#lambda-compute-images
aws/aws-codebuild-docker-images#687

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Jun 19, 2024
…0564)

Add new Lambda dotnet8 compute images for both aarch64 and x86_64 architectures:
- aws/codebuild/amazonlinux-aarch64-lambda-standard:dotnet8
- aws/codebuild/amazonlinux-x86_64-lambda-standard:dotnet8

**References**
- https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html#lambda-compute-images
- #28630
- aws/aws-codebuild-docker-images#719

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
sarangarav pushed a commit to sarangarav/aws-cdk that referenced this pull request Jun 21, 2024
…s#30564)

Add new Lambda dotnet8 compute images for both aarch64 and x86_64 architectures:
- aws/codebuild/amazonlinux-aarch64-lambda-standard:dotnet8
- aws/codebuild/amazonlinux-x86_64-lambda-standard:dotnet8

**References**
- https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html#lambda-compute-images
- aws#28630
- aws/aws-codebuild-docker-images#719

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this pull request Jun 22, 2024
…s#30564)

Add new Lambda dotnet8 compute images for both aarch64 and x86_64 architectures:
- aws/codebuild/amazonlinux-aarch64-lambda-standard:dotnet8
- aws/codebuild/amazonlinux-x86_64-lambda-standard:dotnet8

**References**
- https://docs.aws.amazon.com/codebuild/latest/userguide/build-env-ref-available.html#lambda-compute-images
- aws#28630
- aws/aws-codebuild-docker-images#719

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants