-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): RDS for SQL Server 16 without a specific minor version #28615
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: This PR just adds a version. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@go-to-k we can continue to add any random version specification as a static property, but to what end? Why can't users who need this specific configuration just use the of
API to create it themselves? Is there a large use case for this particular one that makes the syntactic sugar useful?
@kaizencc Of course, one use of this syntactic sugar would be to be able to specify it easily by simple input or selection by completion in an editor. However, I honestly believe that if this is not there, users will be able to use (But I also do think that one way to do it is to say that we'll continue to follow the minor version as we have in the past.) |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@go-to-k I see that we have similar versions for 15 and 14 with no specific minor version, so I think we should provide the same support for 16. I know you have been very gracious in adding new versions as they come, but it is also the antithesis of what cdk is about, which is that you can unlock whatever you want via this enum-like class. It's exceedingly simple to specify your own version with of
, my hope is that people go down that route rather than wait for your manual updates. But maybe thats wishful thinking.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@kaizencc Yes, I really feel the same way. I wish too. |
This PR supports version 16 for RDS for SQL Server without a specific minor version.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license