Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rds): RDS for SQL Server 15.00.4345.5.v1 #28614

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Jan 8, 2024

This PR supports RDS for SQL Server 15.00.4345.5.v1.

aws rds describe-db-engine-versions \
 --engine sqlserver-ee \
 --query "DBEngineVersions[?EngineVersion=='15.00.4345.5.v1'].[DBEngineVersionDescription,EngineVersion,DBParameterGroupFamily,MajorEngineVersion,Status]"

[
    [
        "SQL Server 2019 15.00.4345.5.v1",
        "15.00.4345.5.v1",
        "sqlserver-ee-15.0",
        "15.00",
        "available"
    ]
]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team January 8, 2024 14:15
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Jan 8, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 8, 2024

Exemption Request: This PR just adds a version, and version additions have recently been submitted with feat.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 8, 2024
@kaizencc kaizencc changed the title feat(rds): support RDS for SQL Server 15.00.4345.5.v1 feat(rds): RDS for SQL Server 15.00.4345.5.v1 Jan 8, 2024
@go-to-k
Copy link
Contributor Author

go-to-k commented Jan 8, 2024

Hi @kaizencc , thank you for the approve. But it seems that the auto-merge is not starting, is it because it is not labeled pr-linter/exempt? If so, can you please address this?

@kaizencc kaizencc added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/no-exemption The requested exemption will not be granted to the PR linter result and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jan 8, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 8, 2024 16:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

Copy link
Contributor

mergify bot commented Jan 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9bd7e8e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0f38b6e into aws:main Jan 8, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Jan 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/no-exemption The requested exemption will not be granted to the PR linter result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants