-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): Adds support for DB2 instance creation #28608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this! There are a few things that will be helpful to get started with a meaningful review:
- Integration tests will be important to ensure that the code here actual creates a working CloudFormation template. https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md has some information and you may find other integration tests in
packages/@aws-cdk-testing/framework-integ/test/aws-rds/test
to be helpful in seeing how these tests are done for other RDS instance types. - The build needs to be passing. It looks like the primary failure at the moment is because the PR happened to be opened while the build was in a bad state due to date changing at the new year; updating your branch from
main
should help resolve that failure to see if there are any other issues with the build.
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
The pull request linter fails with the following errors:
PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
The purpose of this issue is to update DatabaseInstance (+ DatabaseInstanceEngine and related classes/interfaces) and add support for RDS with DB2.
Currently 2 versions are handled :
db2-se-11-5 = DB2 Standard Edition v11.5
db2-ae-11.5 = DB2 Advanced Edition v11.5
Closes #28485.
AWS RDS for DB2 official home page
From now, you can create a new RDS for DB2 instance with
DatabaseInstance
constructor as followBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license