Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(opensearchservice): TLS security policy for TLS 1.3 and perfect forward secrecy #28583

Merged
merged 4 commits into from
Jan 8, 2024
Merged

feat(opensearchservice): TLS security policy for TLS 1.3 and perfect forward secrecy #28583

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fc5ed9a
feat(opensearchservice): support TLS 1.3 and perfect forward secrecy
go-to-k Jan 5, 2024
a0a75ef
doc
go-to-k Jan 5, 2024
6d6bf70
change value
go-to-k Jan 5, 2024
30fe757
Merge branch 'main' into opensearch-tls-1-3
mergify[bot] Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/aws-cdk-lib/aws-opensearchservice/lib/domain.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,9 @@ export enum TLSSecurityPolicy {
/** Cipher suite TLS 1.0 */
TLS_1_0 = 'Policy-Min-TLS-1-0-2019-07',
/** Cipher suite TLS 1.2 */
TLS_1_2 = 'Policy-Min-TLS-1-2-2019-07'
TLS_1_2 = 'Policy-Min-TLS-1-2-2019-07',
/** Cipher suite TLS 1.2 to 1.3 with perfect forward secrecy (PFS) */
TLS_1_2_PFS = 'Policy-Min-TLS-1-2-PFS-2023-10',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
TLS_1_2_PFS = 'Policy-Min-TLS-1-2-PFS-2023-10',
TLS_1_3 = 'Policy-Min-TLS-1-2-PFS-2023-10',

I think it's clearer if we specify v1.3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review.

I thought about that too, but do we not have to think about the future appearance of a new option that only allows TLS 1.3 (does not include 1.2)?

Also, there is hesitation in key names that are not in line with the value, what do you think?

}

/**
Expand Down