feat(core): Introduced Duration class #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be used to model durations in a user-friendly way, while
allowing coercion into the desired/required time unit at the usage site.
There is now a default requirement that properties exposed by the APIs
and that have a duration-like name (ending in `duration`, `period`,
`timeout` or `ttl`) have a type of `@aws-cdk/cdk.Duration` and do not
contain a unit suffix (`Days`, `Millis`, `Seconds`, `Sec`, ...).
BREAKING CHANGE: Properties throughout the AWS Construct Libraries that
represent lengths of time have been re-typed to be
`@aws-cdk/cdk.Duration` instead of `number`, and were
renamed to exclude any unit indication.
rix0rrr
reviewed
Jun 17, 2019
eladb
suggested changes
Jun 18, 2019
packages/@aws-cdk/aws-applicationautoscaling/lib/target-tracking-scaling-policy.ts
Show resolved
Hide resolved
1. Dropped the free-floating toSeconds function 2. Added test for unresolved tokens in constructor 3. Made .toString() return a breaking token.
rix0rrr
approved these changes
Jun 20, 2019
eladb
approved these changes
Jun 20, 2019
| @@ -88,8 +88,14 @@ | |||
| "@aws-cdk/aws-s3": "^0.35.0", | |||
| "@aws-cdk/cdk": "^0.35.0" | |||
| }, | |||
| "awslint": { | |||
| "exclude": [ | |||
| "duration-prop-type:@aws-cdk/aws-cloudtrail.TrailProps.cloudWatchLogsRetentionTimeDays", | |||
There was a problem hiding this comment.
Should we just call this cloudWatchLogsRetention?
There was a problem hiding this comment.
I reckon we should!
5 tasks
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
mergify bot
pushed a commit
that referenced
this pull request
Dec 16, 2019
* docs(ecr): fix deprecated requirement maxImageAgeDays - on [Automatically clean up repositories](https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecr-readme.html\#automatically-clean-up-repositories) of Amazon ECR docs, there is deprecated property using on addLifecycleRule example - due to introduce of Duration Class(#2857), it should be maxImageAge rather than maxImageAgeDays * chore(ecr): fix deprecated requirement maxImageAgeDays - maxImageAgeDays were deprecated since #2857, but still used on comments. - should be chaged to maxImageAge - fixes #3273
ed-at-work
pushed a commit
to ed-at-work/aws-cdk
that referenced
this pull request
Dec 17, 2019
* docs(ecr): fix deprecated requirement maxImageAgeDays - on [Automatically clean up repositories](https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecr-readme.html\#automatically-clean-up-repositories) of Amazon ECR docs, there is deprecated property using on addLifecycleRule example - due to introduce of Duration Class(aws#2857), it should be maxImageAge rather than maxImageAgeDays * chore(ecr): fix deprecated requirement maxImageAgeDays - maxImageAgeDays were deprecated since aws#2857, but still used on comments. - should be chaged to maxImageAge - fixes aws#3273
This was referenced Jan 20, 2020
richardhboyd
added a commit
to richardhboyd/aws-cdk
that referenced
this pull request
Mar 24, 2020
Fixed example to align with changes from [this commit](aws#2857)
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2020
Fixed example to align with changes from [this commit](#2857)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can be used to model durations in a user-friendly way, while
allowing coercion into the desired/required time unit at the usage site.
There is now a default requirement that properties exposed by the APIs
and that have a duration-like name (ending in
duration,period,timeoutorttl) have a type of@aws-cdk/cdk.Durationand do notcontain a unit suffix (
Days,Millis,Seconds,Sec, ...).BREAKING CHANGE: Properties throughout the AWS Construct Libraries that
represent lengths of time have been re-typed to be
@aws-cdk/cdk.Durationinstead ofnumber, and wererenamed to exclude any unit indication.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.