feat(codepipeline): change default value for crossAccountKeys to false (under feature flag) #28556

go-to-k · 2024-01-03T10:06:10Z

The documentation mentions updating the default for CDK v2. Sounds like we should add it in with feature flag.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…e (under feature flag)

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

go-to-k · 2024-01-03T10:09:15Z

Exemption Request: This just changes the default value, so unit tests could cover it.

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts

…peline-feature-flag-cross-account-keys

GavinZZ

Thanks for contributing. This change looks good other than some minor question/changes.

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts

packages/aws-cdk-lib/cx-api/lib/features.ts

GavinZZ · 2024-01-30T22:52:11Z

...sting/framework-integ/test/aws-codepipeline-actions/test/integ.cfn-template-from-repo.lit.ts

@@ -52,6 +52,7 @@ const prodStage = {
 };

 new codepipeline.Pipeline(stack, 'Pipeline', {
+  crossAccountKeys: true,


Why do we need to explicitly set it to true? The feature flag is not enabled by default and shouldn't change existing behaviour right?
Same questions for all other places where you added this prop.

It appears that the feature flag is enabled by default for integ tests in CodeBuild CI. I put it all back and got an error in CodeBuild CI.

Changes

~~CodeBuild CI Build log~~ (AccessDenied by Request has expired)

I still tried to go back to the original code to test it out, and the CI was an error.

fd0ee48

However, there is also an integ test where the feature flag remains off by default.

https://github.com/go-to-k/aws-cdk/blob/cba7c75fdd055b1cd48f21fbaa3ab29cf5944693/packages/@aws-cdk-testing/framework-integ/test/aws-cloudwatch-actions/test/integ.lambda-alarm-action.ts#L60-L74

I thought it might be due to a difference in integ.json (this file and the another file) by using new integ.IntegTest() or not, but since I still don't understand how this works, I think I'll leave this PR as is for now. (Because fixing this could be another potentially destructive change.)

I ran the other test (integ.lambda-alarm-action.ts) as a new integ file (with no existing snapshot) to try it out, and it seems that the feature flag is enabled by default.
(Does using new integ.IntegTest() turn off the feature flag with an existing snapshot?)

Either way, I think we're good to go for now.

packages/aws-cdk-lib/cx-api/lib/features.ts

packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md

packages/aws-cdk-lib/cx-api/README.md

packages/aws-cdk-lib/cx-api/FEATURE_FLAGS.md

packages/aws-cdk-lib/aws-codepipeline/test/pipeline.test.ts

packages/@aws-cdk/cx-api/FEATURE_FLAGS.md

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

…peline-feature-flag-cross-account-keys

Pull request has been modified.

This reverts commit 08642e6.

go-to-k · 2024-02-01T08:35:34Z

@GavinZZ @paulhcsun

Thanks for your review. All review comments were reflected. I also have a few comments.

paulhcsun · 2024-02-02T00:11:36Z

Looks good to me, thanks @go-to-k! I'll defer the approval to @GavinZZ.

This reverts commit 1b3166b.

This reverts commit fd0ee48.

GavinZZ

LGTM, thanks for contributing!

mergify · 2024-02-02T17:56:56Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

aws-cdk-automation · 2024-02-02T18:24:11Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 460316d
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-02-02T18:24:32Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

…e (under feature flag) (#28556) [The documentation](https://github.com/aws/aws-cdk/blob/f4c1d1253ee34c2837a57a93faa47c9da97ef6d8/packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts#L380-L381) mentions updating the default for CDK v2. Sounds like we should add it in with feature flag. Closes #28247. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

feat(codepipeline): change default value for crossAccountKeys to fals…

8907d37

…e (under feature flag)

aws-cdk-automation requested a review from a team January 3, 2024 10:06

github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1 labels Jan 3, 2024

aws-cdk-automation previously requested changes Jan 3, 2024

View reviewed changes

aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 3, 2024

docs

5839650

go-to-k commented Jan 3, 2024

View reviewed changes

packages/aws-cdk-lib/aws-codepipeline/lib/pipeline.ts Show resolved Hide resolved

go-to-k added 3 commits January 3, 2024 19:25

change doc

62ed55a

change integ tests

a58c695

change rest integ tests

51b70da

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 3, 2024

go-to-k added 3 commits January 26, 2024 16:48

Merge branch 'main' of https://github.com/go-to-k/aws-cdk into codepi…

692b2a5

…peline-feature-flag-cross-account-keys

change integ

700ae9e

Merge branch 'main' of https://github.com/go-to-k/aws-cdk into codepi…

c3f812e

…peline-feature-flag-cross-account-keys

GavinZZ self-requested a review January 30, 2024 22:09

GavinZZ previously requested changes Jan 30, 2024

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 30, 2024

GavinZZ reviewed Jan 30, 2024

View reviewed changes

packages/aws-cdk-lib/cx-api/lib/features.ts Outdated Show resolved Hide resolved

paulhcsun previously requested changes Jan 30, 2024

View reviewed changes

paulhcsun added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jan 30, 2024

github-actions bot mentioned this pull request Feb 1, 2024

Monthly PR metrics report - Jan 2024 #28952

Closed

Merge branch 'main' of https://github.com/go-to-k/aws-cdk into codepi…

64296d2

…peline-feature-flag-cross-account-keys

change docs

670114b

go-to-k added 5 commits February 1, 2024 16:09

change test name

cccd4a5

explain for feature flag

4bf9095

change integ tests

08642e6

Revert "change integ tests"

5f804ee

This reverts commit 08642e6.

docs

d4ce487

go-to-k requested review from GavinZZ and paulhcsun February 1, 2024 08:36

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 1, 2024

go-to-k added 4 commits February 2, 2024 14:40

test build for feature flag in integ test

fd0ee48

test build for feature flag using IntegTest

1b3166b

Revert "test build for feature flag using IntegTest"

28852df

This reverts commit 1b3166b.

Revert "test build for feature flag in integ test"

cba7c75

This reverts commit fd0ee48.

GavinZZ approved these changes Feb 2, 2024

View reviewed changes

Merge branch 'main' into codepipeline-feature-flag-cross-account-keys

460316d

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Feb 2, 2024

mergify bot merged commit 144b1b9 into aws:main Feb 2, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codepipeline): change default value for crossAccountKeys to false (under feature flag) #28556

feat(codepipeline): change default value for crossAccountKeys to false (under feature flag) #28556

go-to-k commented Jan 3, 2024 •

edited

Loading

aws-cdk-automation left a comment

go-to-k commented Jan 3, 2024

GavinZZ left a comment

GavinZZ Jan 30, 2024

go-to-k Feb 1, 2024 •

edited

Loading

go-to-k Feb 2, 2024 •

edited

Loading

go-to-k Feb 2, 2024

go-to-k commented Feb 1, 2024 •

edited

Loading

paulhcsun commented Feb 2, 2024

GavinZZ left a comment

mergify bot commented Feb 2, 2024

aws-cdk-automation commented Feb 2, 2024

mergify bot commented Feb 2, 2024

feat(codepipeline): change default value for crossAccountKeys to false (under feature flag) #28556

feat(codepipeline): change default value for crossAccountKeys to false (under feature flag) #28556

Conversation

go-to-k commented Jan 3, 2024 • edited Loading

aws-cdk-automation left a comment

Choose a reason for hiding this comment

go-to-k commented Jan 3, 2024

GavinZZ left a comment

Choose a reason for hiding this comment

GavinZZ Jan 30, 2024

Choose a reason for hiding this comment

go-to-k Feb 1, 2024 • edited Loading

Choose a reason for hiding this comment

go-to-k Feb 2, 2024 • edited Loading

Choose a reason for hiding this comment

go-to-k Feb 2, 2024

Choose a reason for hiding this comment

go-to-k commented Feb 1, 2024 • edited Loading

paulhcsun commented Feb 2, 2024

GavinZZ left a comment

Choose a reason for hiding this comment

mergify bot commented Feb 2, 2024

aws-cdk-automation commented Feb 2, 2024

AWS CodeBuild CI Report

mergify bot commented Feb 2, 2024

go-to-k commented Jan 3, 2024 •

edited

Loading

go-to-k Feb 1, 2024 •

edited

Loading

go-to-k Feb 2, 2024 •

edited

Loading

go-to-k commented Feb 1, 2024 •

edited

Loading