Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lambda-go): path with space breaks go build #28554

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

longtv2222
Copy link
Contributor

@longtv2222 longtv2222 commented Jan 3, 2024

Output path with space breaks go build

Solution: quoting go build output path

Closes #28555


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 3, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team January 3, 2024 04:37
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added the bug This issue is a bug. label Jan 3, 2024
@longtv2222 longtv2222 changed the title fix(aws-lambda-go-alpha): path with space breaks go build fix(lambda-go-alpha): path with space breaks go build Jan 3, 2024
@longtv2222
Copy link
Contributor Author

longtv2222 commented Jan 3, 2024

Exemption Request

Cannot add meaningful integration tests for this fix since:

  • This is only reproducible when Window home directory contains space(s)
  • The fix does not result in changing snapshots

@longtv2222 longtv2222 marked this pull request as ready for review January 3, 2024 05:50
@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Jan 3, 2024
@kaizencc kaizencc added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Jan 3, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 3, 2024 15:10

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@kaizencc kaizencc removed the pr-linter/exempt-test The PR linter will not require test changes label Jan 3, 2024
@kaizencc kaizencc changed the title fix(lambda-go-alpha): path with space breaks go build fix(lambda-go): path with space breaks go build Jan 3, 2024
Copy link
Contributor

mergify bot commented Jan 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1b4f978
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a8a639e into aws:main Jan 3, 2024
9 checks passed
Copy link
Contributor

mergify bot commented Jan 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@longtv2222 longtv2222 deleted the go-build-breaks-with-space branch January 3, 2024 16:43
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this pull request Jan 5, 2024
Output path with space breaks go build

Solution: quoting `go build` output path

Closes aws#28555

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lambda-go-alpha: go build breaks with spaces in path
3 participants