feat(codepipeline-actions): Add CAPABILITY_AUTO_EXPAND (#2851) #2852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: the capabilities property is now an array to support multiple capabilities. Adds CAPABILITY_AUTO_EXPAND and support to define a list of capabilities for the CodePipeline action.
Properly handle CloudFormationCapabilities.None
Update app-handler to support capabilities[]
RomainMuller
changed the title
| if (adminPermissions && capabilities === undefined) { | ||
| // admin true default capability to NamedIAM | ||
| return cfn.CloudFormationCapabilities.NamedIAM; | ||
| return [cfn.CloudFormationCapabilities.NamedIAM]; |
There was a problem hiding this comment.
I wonder if this should not contain AutoExpand, too.
There was a problem hiding this comment.
Yes, makes sense, I've added it. Please let me know if the changes are acceptable.
| adminPermissions: false, | ||
| }); | ||
| new PipelineDeployStackAction(pipelineStack, 'DeployStack2', { | ||
| stage: selfUpdateStage3, | ||
| stack: stackWithAnonymousCapability, | ||
| input: selfUpdatingStack.synthesizedApp, | ||
| capabilities: cfn.CloudFormationCapabilities.AnonymousIAM, | ||
| capabilities: [cfn.CloudFormationCapabilities.AnonymousIAM], |
There was a problem hiding this comment.
Would like to have an additional test that uses AutoExpand.
There was a problem hiding this comment.
Added a couple more tests.
| @@ -540,3 +540,14 @@ interface StatementTemplate { | |||
| } | |||
|
|
|||
| type StatementCondition = { [op: string]: { [attribute: string]: string } }; | |||
|
|
|||
| function parseCapabilities(capabilities: any): any { | |||
There was a problem hiding this comment.
Can we avoid using any here? I would rather those be tightly typed as much as possible.
There was a problem hiding this comment.
Yes, sorry for missing out on this one. I've updated the function.
Update capabilities() function with strong types.
Add CAPABILITY_AUTO_EXPAND to the default capabilities of the CloudFormation stack deploy role.
|
@RomainMuller sorry, I was delayed resolving the merge conflict. It should be alright now. |
rix0rrr
approved these changes
Jun 21, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: the capabilities property is now an array to support multiple capabilities.
Adds CAPABILITY_AUTO_EXPAND and support to define a list of capabilities for the CodePipeline action.
Closes #2851