Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CodePipelineActions): Add support for custom events in CodeCommit source action #28008

Merged
merged 24 commits into from
Jan 16, 2024
Merged

feat(CodePipelineActions): Add support for custom events in CodeCommit source action #28008

merged 24 commits into from
Jan 16, 2024

Conversation

jolo-dev
Copy link
Contributor

Custom Events were added to the CodeCommit Source action to trigger pipelines via custom event rules.

Closes #12045.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 15, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team November 15, 2023 13:52
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 15, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@jolo-dev jolo-dev changed the title Add support for custom events in CodeCommit source action feat(CodePipelineActions): Add support for custom events in CodeCommit source action Nov 15, 2023
@scanlonp
Copy link
Contributor

Hey @jolo-dev, please run the integ runner to generate a snapshot for your new integ test! Make sure you are using the .js file to generate the snapshot folder.

@aws-cdk-automation aws-cdk-automation dismissed their stale review November 18, 2023 00:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@jolo-dev jolo-dev marked this pull request as ready for review November 18, 2023 00:03
@jolo-dev jolo-dev force-pushed the jolo-dev/custom-event-for-codepipeline-codecommit-actions branch from aac6369 to fd69fc8 Compare November 30, 2023 10:36
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 30, 2023
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
paulhcsun
paulhcsun previously requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments for some minor changes

packages/aws-cdk-lib/aws-codepipeline-actions/lib/codecommit/source-action.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-codepipeline-actions/lib/codecommit/source-action.ts Outdated Show resolved Hide resolved
packages/aws-cdk-lib/aws-codepipeline-actions/lib/codecommit/source-action.ts Outdated Show resolved Hide resolved
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 3, 2024
@mergify mergify bot dismissed paulhcsun’s stale review January 13, 2024 16:28

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 13, 2024
@jolo-dev
Copy link
Contributor Author

jolo-dev commented Jan 13, 2024 •
edited
Loading

@paulhcsun I have addressed your suggestions, but CodeBuild is failing... Maybe you can direct me in the right direction on what to change.

@jolo-dev
Copy link
Contributor Author

@paulhcsun Awesome! Thank you!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 15, 2024
@mergify mergify bot dismissed paulhcsun’s stale review January 16, 2024 08:10

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 16, 2024
paulhcsun
paulhcsun approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@paulhcsun paulhcsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @jolo-dev! This will be a helpful win for the community!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d2616f5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c3802c4 into aws:main Jan 16, 2024
11 checks passed
@jolo-dev jolo-dev deleted the jolo-dev/custom-event-for-codepipeline-codecommit-actions branch January 17, 2024 18:57
This was referenced Feb 10, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulhcsun paulhcsun paulhcsun approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(codepipeline-actions): custom event for codepipeline codecommit actions
4 participants
@jolo-dev @scanlonp @aws-cdk-automation @paulhcsun