Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codebuild): API cleanup #2745

Merged
merged 1 commit into from
Jun 18, 2019
Merged

fix(codebuild): API cleanup #2745

merged 1 commit into from
Jun 18, 2019

Commits on Jun 17, 2019

  1. fix(codebuild): API cleanup. 

    Change the names of the source classes to be more consistent with other integrations.
Introduce an ISource interface. Make all Source subclasses package-private,
and use static factory methods on Source (renamed from BuildSource) instead.

Change the names of artifacts classes to be more consistent with other integrations.
Introduce the IArtifacts interface. Make all Artifacts subclasses package-private,
and use static factory methods on Artifacts (renamed from BuildArtifacts) instead.

Get rid of the SourceType enum.

Remove the buildScriptAsset and buildScriptAssetEntrypoint properties.

Make Project implements ec2.IConnectable instead of exposing secuirtyGroups directly.

BREAKING CHANGE:
* codebuild: rename BuildSource to Source, BuildArtifacts to Artifacts
* codebuild: all Source and Artifacts classes can only be created through static factory methods instead of constructors
* codebuild: the construction properties buildScriptAsset and buildScriptAssetEntrypoint were removed
* codebuild: the Projet.securityGroups property has been removed; Project now implements ec2.IConnectable instead
    @skinny85
    skinny85 committed Jun 17, 2019
    Configuration menu
    Copy the full SHA
    6403b4f View commit details
    Browse the repository at this point in the history