Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cloudwatch): move SNS Alarm Action to aws-cloudwatch-actions #2688

Merged
merged 9 commits into from
Jun 5, 2019
Merged

fix(cloudwatch): move SNS Alarm Action to aws-cloudwatch-actions #2688

merged 9 commits into from
Jun 5, 2019

Commits on May 30, 2019

  1. fix(cloudwatch): Move SNS Alarm Action to aws-cloudwatch-actions. 

    In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing
CloudWatch Alarm Actions into `@aws-cdk/aws-cloudwatch-actions`.

Not moving AutoScaling classes because doing so would introduce circular
dependencies.

BREAKING CHANGE: using an SNS topic as CloudWatch Alarm Actxion now
requires an integration object from the `@aws-cdk/aws-cloudwatch-actions`
package.
    @rix0rrr
    rix0rrr committed May 30, 2019
    Configuration menu
    Copy the full SHA
    47e84c5 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2019

  1. Duplicate scaling actions to integration module

    @rix0rrr
    rix0rrr committed May 31, 2019
    Configuration menu
    Copy the full SHA
    c4ce495 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into huijbers/alarm-actions

    @rix0rrr
    rix0rrr committed May 31, 2019
    Configuration menu
    Copy the full SHA
    1aa279a View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2019

  1. Merge remote-tracking branch 'origin/master' into huijbers/alarm-actions

    @rix0rrr
    rix0rrr committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    e8d1619 View commit details
    Browse the repository at this point in the history

  2. Update package locks

    @rix0rrr
    rix0rrr committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    37ad9e4 View commit details
    Browse the repository at this point in the history

  3. Rename all bind() return values to "Props"

    @rix0rrr
    rix0rrr committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    c45553e View commit details
    Browse the repository at this point in the history

  4. Rename all suffixes => "Config"

    @rix0rrr
    rix0rrr committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    59e63dc View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin/master' into huijbers/alarm-actions

    @rix0rrr
    rix0rrr committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    c8bae1b View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Fix straggler

    @rix0rrr
    rix0rrr committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    befc3c4 View commit details
    Browse the repository at this point in the history