Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pr-linter/do-not-close never worked #26762

Merged
merged 2 commits into from
Aug 15, 2023
Merged

chore: pr-linter/do-not-close never worked #26762

merged 2 commits into from
Aug 15, 2023

Conversation

kaizencc
Copy link
Contributor

We have a label, pr-linter/do-not-close that has not been doing its job. See #26039.

It is because we are expecting a comma-separated-list, without spaces:

https://github.com/rix0rrr/close-stale-prs/blob/ffeb148adbaf7402e77bc4eafce8ed3d3c40f29c/src/index.ts#L22


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 15, 2023 17:51
@github-actions github-actions bot added the p2 label Aug 15, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 15, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1ff9f0f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6a76aca into main Aug 15, 2023
@mergify mergify bot deleted the conroy/do-not-close branch August 15, 2023 20:12
@mergify
Copy link
Contributor

mergify bot commented Aug 15, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants