Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "chore(ground-station): Scaffold AWS Ground Station alpha" #26704

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Aug 10, 2023

Breaks our build. I think it is because there is nothing in index.ts but this does not seem like a big enough pr to block a release over, so am reverting.

npx tsc
ts-import.ts(18,51): error TS2306: 
File 
'/tmp/tmp.QUQUtYehRM/node_modules/@aws-cdk/aws-groundstation-alpha/lib/index.d.ts'
 is not a module.</span>

New packages should always run through the test pipeline before merge.

@github-actions github-actions bot added the p2 label Aug 10, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 10, 2023 13:37
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 10, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8affd7d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b551af0 into main Aug 10, 2023
@mergify mergify bot deleted the revert-26683-ground-station-alpha branch August 10, 2023 15:07
@mergify
Copy link
Contributor

mergify bot commented Aug 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

waormd added a commit to waormd/aws-cdk that referenced this pull request Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants