fix(core): hide dependencyRoots from public API
#2668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IDependable` is now a marker interface, and signals that there is a `DependableTrait` implementation which can be retrieved which contains the actual implementation of `dependencyRoots` for this instance. Fixes #2348.
rix0rrr
force-pushed
the
huijbers/private-interfaces
branch
from
14544b2
to
ce4db50
Compare
eladb
reviewed
May 29, 2019
| @@ -596,6 +588,11 @@ export class Construct implements IConstruct { | |||
| */ | |||
| constructor(scope: Construct, id: string) { | |||
| this.node = new ConstructNode(this, scope, id); | |||
|
|
|||
| const self = this; | |||
There was a problem hiding this comment.
put a wee comment explaining what this does
| * explicitly. This is used to implement certain framework features that are | ||
| * not intended to be used by Construct consumers, and so should be hidden | ||
| * from accidental use. | ||
| */ |
| @@ -27,17 +24,61 @@ export interface IDependable { | |||
| export class ConcreteDependable implements IDependable { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh nice. for some reason I thought it is just introduced now.
eladb
approved these changes
May 29, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDependableis now a marker interface, and signals that there isa
DependableTraitimplementation which can be retrieved which containsthe actual implementation of
dependencyRootsfor this instance.Fixes #2348.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.