Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-ecs): refactor high level aws-ecs constructs into the aws-ecs-patterns module #2623

Merged
merged 3 commits into from
May 24, 2019

Conversation

piradeepk
Copy link
Contributor

@piradeepk piradeepk commented May 23, 2019

Refactored all high level constructs from the aws-ecs module into the aws-ecs-patterns module as discussed offline.

BREAKING CHANGE: These changes move all L3 and higher constructs out of the aws-ecs module into the aws-ecs-patterns module. The following constructs have been moved into the aws-ecs-patterns module: EcsQueueWorkerService, FargateQueueWorkerService, LoadBalancedEcsService, LoadBalancedFargateService and LoadBalancedFargateServiceApplets.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@piradeepk piradeepk requested review from SoManyHs and a team as code owners May 23, 2019 18:09
@Doug-AWS
Copy link
Contributor

@awslabs/aws-cdk-team Are we going to follow this model? Do we want to come up with what we call these? CDK Pattern Resources?

@rix0rrr
Copy link
Contributor

rix0rrr commented May 24, 2019

I would call this a fix and it needs a BREAKING CHANGE notice for the classes you moved.

@piradeepk piradeepk changed the title chore(aws-ecs): refactor high level aws-ecs constructs into the aws-ecs-patterns module fix(aws-ecs): refactor high level aws-ecs constructs into the aws-ecs-patterns module May 24, 2019
@piradeepk
Copy link
Contributor Author

I would call this a fix and it needs a BREAKING CHANGE notice for the classes you moved.

Updated the title to be fix, and added a BREAKING CHANGE notice.

@rix0rrr rix0rrr merged commit f901313 into aws:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants