Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aws-glue): fix glue tableArn and integer schema name #2585

Merged
merged 4 commits into from
May 21, 2019
Merged

fix(aws-glue): fix glue tableArn and integer schema name #2585

merged 4 commits into from
May 21, 2019

Conversation

sam-goodwin
Copy link
Contributor

Two fixes for aws-glue Table:

  • format the tableArn according to the docs: database was mistakenly used as the resource instead of table.
  • rename the 32-bit INTEGER type from integer to int or else deploying the table fails.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@sam-goodwin sam-goodwin added the @aws-cdk/aws-glue Related to AWS Glue label May 20, 2019
@sam-goodwin sam-goodwin requested a review from a team as a code owner May 20, 2019 06:01
this.tableArn = this.node.stack.formatArn({
service: 'glue',
resource: 'table',
resourceName: Fn.join('', [this.database.databaseName, '/', this.tableName])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a string interpolation (what was previously in tableArn). Why the explicit Fn.Join? Does something break if we do it the other way?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't think to use string interpolation. Fixed now.

@rix0rrr rix0rrr self-assigned this May 20, 2019
@rix0rrr rix0rrr merged commit 99e173e into aws:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-glue Related to AWS Glue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants