Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-codepipeline): #2572 allow IAM Role to be passed to Pipeline #2573

Closed
wants to merge 5 commits into from
Closed

feat(aws-codepipeline): #2572 allow IAM Role to be passed to Pipeline #2573

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c66b4d
feat(aws-codepipeline): #2572 allow IAM Role to be passed to CodePipe…
AlexChesters May 17, 2019
f2f086a
feat(codebuild): add support for local cache modes (#2529)
May 17, 2019
c6fc3fa
refactor: remove "export"s and normalize resource names (#2580)
May 18, 2019
01daa12
inline IAM role assignment
AlexChesters May 20, 2019
b88d95d
update docstring to be more precise
AlexChesters May 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions packages/@aws-cdk/aws-codepipeline/lib/pipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ export interface PipelineProps {
*/
readonly artifactBucket?: s3.IBucket;

/**
* The IAM role to be assumed by this Pipeline.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be a little more precise here? "The IAM role used for executing this Pipeline. If not specified, a new IAM role, trusting the CodePipeline service principal, will be created".

* If not specified, a new IAM role will be created.
*/
readonly role?: iam.Role;

/**
* Indicates whether to rerun the AWS CodePipeline pipeline after you update it.
*/
Expand Down Expand Up @@ -233,9 +239,14 @@ export class Pipeline extends PipelineBase {
}
this.artifactBucket = propsBucket;

this.role = new iam.Role(this, 'Role', {
assumedBy: new iam.ServicePrincipal('codepipeline.amazonaws.com')
});
// If a role has been provided, use it - otherwise, create a role.
let propsRole = props.role;
if (!propsRole) {
propsRole = new iam.Role(this, 'Role', {
assumedBy: new iam.ServicePrincipal('codepipeline.amazonaws.com')
});
}
this.role = propsRole;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually write it in one line:

this.role = props.role || new iam.Role(this, 'Role', {
  assumedBy: new iam.ServicePrincipal('codepipeline.amazonaws.com')
});


const codePipeline = new CfnPipeline(this, 'Resource', {
artifactStore: new Token(() => this.renderArtifactStore()) as any,
Expand Down