Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-ecs): add ECS/Fargate QueueWorkerService constructs #2568
feat(aws-ecs): add ECS/Fargate QueueWorkerService constructs #2568
Changes from all commits
d5baf5d
f8eeb3e
222020d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessarily something to address here, but noting for posterity that we repeat these props (and their associated docstrings) a lot in the L3 constructs (both EC2 and Fargate) -- might be worth considering refactoring at some point, pending some of the discussion on how to handle these higher level constructs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, the only think we would need to consider is if the launchtype is Fargate, then it should default to (256 cpu or 512 memoryMiB) where as memory is be a required property for EC2 services (memoryLimit or memoryReservationLimit). It's not difficult, but we would be impacting readability and maintainability of the base classes. Thoughts?
@clareliguori what do you think?