Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use interface references in public api (awslint:ref-via-interface) #2499

Merged
merged 12 commits into from
May 8, 2019
Merged

refactor: use interface references in public api (awslint:ref-via-interface) #2499

merged 12 commits into from
May 8, 2019

Commits on May 8, 2019

  1. refactor: use interface references in public api (awslint:ref-via-int… 

    …erface)

Adds a new awslint:ref-via-interface rule which validates that all input APIs
(e.g. props, method arguments) use construct interface (IBucket) and not concrete
classes (Bucket). This is in order to enable passing in unowned resources and
in accordance with the aws construct library guidelines.

There are situations where an owned resource is required. In those, the rule
can be disabled by adding [disable-awslint:ref-via-interface] to the element's
inline documentation.

To enable this, the following new construct interfaces were added, along with `fromXxx` import methods:
* `applicationautoscaling.IScalableTarget`
* `cloudwatch.IAlarm`
* `ecs.IService`
* `ecs.IEc2Service`
* `ec2.IFargateService`
* `ecs.ITaskDefinition`
* `iam.IGroup`
* `iam.IUser`
* `iam.IPolicy`
* `lambda.IVersion`

BREAKING CHANGE: `apigateway.ResourceBase.trackChild` is now internal.
* `cloudfront.S3OriginConfig.originAccessIdentity` is now `originAccessIdentityId`
* `codedeploy.LambdaDeploymentGroup.alarms` is now `cloudwatch.IAlarm[]` (previously `cloudwatch.Alarm[]`)
* `codepipeline.crossRegionScaffoldingStacks` renamed to `crossRegionScaffolding`
* `codepipeline.CrossRegionScaffoldingStack` renamed to `codepipeline.CrossRegionScaffolding` and cannot be instantiated (abstract)
* `ec2.VpcSubnet.addDefaultRouteToNAT` renamed to `addDefaultNatRoute` and made public
* `ec2.VpcSubnet.addDefaultRouteToIGW` renamed to `addDefaultInternetRoute`, made public and first argument is the gateway ID (string) and not the CFN L1 class
* `ecs.Ec2EventRuleTarget.taskDefinition` is now `ITaskDefinition` (previously `TaskDefinition`)
* `lambda.IEventSource.bind` now accepts `IFunction` instead of `FunctionBase`. Use `IFunction.addEventSourceMapping` to add an event source mapping under the function.
* `lambda.Layer.grantUsage` renamed to `lambda.layer.addPermission` and returns void
* `stepfunctions.StateMachine.role` is now `iam.IRole` (previously `iam.Role`)
    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    1ff8a42 View commit details
    Browse the repository at this point in the history

  2. cr fixes

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    ee06ce0 View commit details
    Browse the repository at this point in the history

  3. fix cycle requires

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    a7b0d9e View commit details
    Browse the repository at this point in the history

  4. Misc fixes 

    * add VpcSubnet.isVpcSubnet
* Do not use arbitrary duck-typing in EKS
    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    5f72275 View commit details
    Browse the repository at this point in the history

  5. fix ecs tests

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    a1d7a7b View commit details
    Browse the repository at this point in the history

  6. fix event source tests

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    1edb61e View commit details
    Browse the repository at this point in the history

  7. validate explicit stack name instead of construct id

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    549bf24 View commit details
    Browse the repository at this point in the history

  8. update decdk snapshot

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    06ad626 View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'origin/master' into benisrae/ref-via-in… 

    …terface
    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    7603d26 View commit details
    Browse the repository at this point in the history

  10. fix merge issues

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    c339fca View commit details
    Browse the repository at this point in the history

  11. fix compat.

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    c4b1486 View commit details
    Browse the repository at this point in the history

  12. fix API

    Elad Ben-Israel committed May 8, 2019
    Configuration menu
    Copy the full SHA
    9c767c1 View commit details
    Browse the repository at this point in the history