feat(cloudwatch): add support for yAxis to graph #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support setting for the y-axis on a graph: min, max, label, and showUnits. Fixes aws#2385
eladb
previously requested changes
May 1, 2019
| /** | ||
| * Whether to show units | ||
| * | ||
| * @default None (means true) |
| */ | ||
| readonly leftAxisRange?: YAxisRange; | ||
| readonly leftYAxis?: YAxis; |
There was a problem hiding this comment.
This seems like a breaking change. Please update the PR description to describe it per the instructions in the contribution guide
| /** | ||
| * An Y-Axis on a CloudWatch dashboard widget | ||
| */ | ||
| export class YAxis { |
There was a problem hiding this comment.
I think this class can be an interface and merge with YAxisProps
added 3 commits
May 14, 2019 16:08
Support setting for the y-axis on a graph: min, max, label, and showUnits. Fixes aws#2385
kpiljoong
requested review from
Doug-AWS,
RomainMuller,
skinny85 and
SoManyHs
as code owners
added 2 commits
May 24, 2019 17:10
rix0rrr
approved these changes
May 24, 2019
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 12, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support setting for the y-axis on a graph: min, max, label, and showUnits.
Fixes #2385
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.