fix(pipelines): cross-stack step dependencies have wrong name #23594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to immediately recurse into the dependencies of a Step, and add a new Node for them to the current Graph if they didn't exist yet. This was originally written like this to support `inputs` for the `ShellSteps`, which would automatically add in any necessary Nodes into the same Graph as necessary without explicitly adding them. However, it would also have the effect that Steps which **would have** been added to the Graph would be parented incorrectly (they would be eagerly added to the wrong parent). Do this in two stages now: first try to resolve all step dependencies between things that are added to the graph, then create new Nodes for missing Step dependencies later. Fixes #21843.
|
|
github-actions
bot
added
bug
aws-cdk-automation
previously requested changes
Jan 6, 2023
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
Naumel
approved these changes
Jan 17, 2023
| public first() { | ||
| const nodes = new Set(this.nodes); | ||
| const sorted = this.nodes[0].rootGraph.sortedLeaves(); | ||
| for (const tranche of sorted) { |
There was a problem hiding this comment.
[tangent][non-blocking] An unexpected word: tranche: portion.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to immediately recurse into the dependencies of a Step, and add a new Node for them to the current Graph if they didn't exist yet.
This was originally written like this to support
inputsfor theShellSteps, which would automatically add in any necessary Nodes into the same Graph as necessary without explicitly adding them.However, it would also have the effect that Steps which would have been added to the Graph would be parented incorrectly (they would be eagerly added to the wrong parent).
Do this in two stages now: first try to resolve all step dependencies between things that are added to the graph, then create new Nodes for missing Step dependencies later.
Fixes #21843.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license