feat(core): stack synthesizers can be shared between stacks #23571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `StackSynthesizer` instances must be created fresh for each `Stack`. This makes it impossible to do things like specify the stack synthesizer once at the root of the construct tree (`App`), for example. Lift that restriction: instances of default stack synthesizers can now be shared between multiple Stacks. User-written stack synthesizers can not magically be shared, but they can be made shareable by implementing `IReusableStackSynthesizer`. Immediately add the feature of specyfing a single Stack Synthesizer at the top level.
rix0rrr
added
pr-linter/exempt-readme
|
|
corymhall
approved these changes
Jan 17, 2023
| * context keys have an unguessable prefix that is different on each execution. | ||
| */ | ||
|
|
||
| const PREFIX = `aws-cdk-private:${Math.random()}:`; |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
StackSynthesizerinstances must be created fresh for eachStack. This makes it impossible to do things like specify the stack synthesizer once at the root of the construct tree (App), for example.Lift that restriction: instances of default stack synthesizers can now be shared between multiple Stacks. User-written stack synthesizers can not magically be shared, but they can be made shareable by implementing
IReusableStackSynthesizer.Immediately add the feature of specyfing a single Stack Synthesizer at the top level.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license