Skip to content

feat(appsync): js resolver support #23551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 6, 2023
Merged

feat(appsync): js resolver support #23551

merged 4 commits into from
Jan 6, 2023

Conversation

@MrArnoldPalmer
Copy link
Contributor

@MrArnoldPalmer MrArnoldPalmer commented Jan 4, 2023 •
edited
Loading

Adds support for resolvers using the APPSYNC_JS runtime. Adds new props
for specifying Code and Runtime on both Resolver and Function
constructs. Adds Code class with asset support for local files and
inline code.

Adds integ test covering basic JS function/resolver usage.

Fix: #22921

@gitpod-io
Copy link

gitpod-io bot commented Jan 4, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team January 4, 2023 00:53
@github-actions github-actions bot added the p2 label Jan 4, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 4, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@MrArnoldPalmer MrArnoldPalmer force-pushed the feat/appsync-js-resolvers branch from 07f7057 to 94ca302 Compare January 4, 2023 20:43
@MrArnoldPalmer
feat(appsync): js resolver support
6578944 
Adds support for resolvers using the APPSYNC_JS runtime. Adds new props
for specifying `Code` and `Runtime` on both `Resolver` and `Function`
constructs. Adds `Code` class with asset support for local files and
inline code.

Adds integ test covering basic JS function/resolver usage.
@MrArnoldPalmer MrArnoldPalmer force-pushed the feat/appsync-js-resolvers branch from 94ca302 to 6578944 Compare January 4, 2023 20:52
@aws-cdk-automation aws-cdk-automation dismissed their stale review January 4, 2023 20:54

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@MrArnoldPalmer MrArnoldPalmer marked this pull request as ready for review January 4, 2023 22:54
corymhall
corymhall suggested changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of comments

onlybakam
onlybakam reviewed Jan 5, 2023
View reviewed changes
onlybakam
onlybakam reviewed Jan 5, 2023
View reviewed changes
onlybakam
onlybakam reviewed Jan 5, 2023
View reviewed changes
onlybakam
onlybakam reviewed Jan 5, 2023
View reviewed changes
@MrArnoldPalmer MrArnoldPalmer requested review from corymhall and onlybakam and removed request for onlybakam January 5, 2023 21:21
onlybakam
onlybakam approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@onlybakam onlybakam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Jan 6, 2023

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 529f332
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2318384 into main Jan 6, 2023
@mergify mergify bot deleted the feat/appsync-js-resolvers branch January 6, 2023 21:02
@mergify
Copy link
Contributor

mergify bot commented Jan 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@abhi211199
Copy link

abhi211199 commented Jan 13, 2023

Thanks for this feature!
When can we expect the latest version(2.60.0) of aws-appsync-alpha in https://www.npmjs.com/package/@aws-cdk/aws-appsync-alpha package?

@hoegertn
Copy link
Contributor

hoegertn commented Jan 13, 2023

AppSync was merged to core in 2.60.0 so no alpha package needed anymore.

@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aws-cdk-automation aws-cdk-automation Awaiting requested review from aws-cdk-automation

2 more reviewers

@onlybakam onlybakam onlybakam approved these changes

@corymhall corymhall corymhall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-appsync: javascript resolver support

6 participants

@MrArnoldPalmer @aws-cdk-automation @abhi211199 @hoegertn @onlybakam @corymhall