chore(servicecatalogappregistry): providing default values for CreateApplicationTargetOptions #22890
Conversation
|
|
github-actions
bot
added
the
beginning-contributor
rohitagg0807
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
| const applicationStack = new cdk.Stack(scope, stackId, this.applicationOptions); | ||
| const appRegApplication = new Application(applicationStack, 'DefaultCdkApplication', { | ||
| applicationName: this.applicationOptions.applicationName, | ||
| description: this.applicationOptions.applicationDescription, | ||
| description: this.applicationOptions.applicationDescription || 'AppRegistry Application to which all stacks inside this cdkApp will get associated.', |
There was a problem hiding this comment.
When you look at the description in the console, the words "this cdkApp" are meaningless.
There was a problem hiding this comment.
We are trying to tell the purpose of the creation of the app. I agree this cdkApp is useless. How about this ?
AppRegistry Application to which all stacks inside the cdkApp will get associated.
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license