Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-cloudwatch): add support for non-widget fields in dashboard body #2248

Merged
merged 2 commits into from
Apr 12, 2019

Conversation

clareliguori
Copy link
Member

Adding start, end, and periodOverride from https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@clareliguori clareliguori requested a review from a team as a code owner April 11, 2019 15:20
@sam-goodwin
Copy link
Contributor

Unit test?

@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 12, 2019

I don't understand the link between PR content and title. Title says something about widgets, content seems to be about adding a period to the dashboard.

@clareliguori
Copy link
Member Author

Title refers to adding all remaining fields in dashboard body format other than widget, which is already supported

@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 12, 2019

Ohhh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants