fix(aws-lambda-nodejs): Default entry finding when Node returns paths starting with file://

[okko]

Fixes #21630.

Stack filenames contain file:// prefix in ES module files. This removes the prefix for Node compatibility.

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[okko]

@corymhall Please advice if I should change findEntry to be exported so that I can add tests for this case. I'm not sure how to create a test scenario using only the currently exported NodejsFunction.

[corymhall]

Please advice if I should change findEntry to be exported so that I can add tests for this case. I'm not sure how to create a test scenario using only the currently exported NodejsFunction.

I think we can add a test in function.test.ts. It seems like all that is needed to reproduce the issue is to have a package.json with "type": "module". If that is the case we could just add new test directory with a package.json and handler file.

[TheRealAmazonKendra]

I would like to see an integration test for this. It's not part of our PRLinter just yet (change coming soon) but we are now requiring integ tests on fixes.

[okko]

An integration test would require the test tooling to compile the test case project to ESM and then synthesize that. I believe that would require a separate package.json, tsconfig.json, jest config, cdk.json that executes ts-node in esm mode, and hooking that into the way the tests run. I'm not familiar enough with the aws-cdk development tooling to do all of that, and I think that shouldn't be in the scope of this fix. I have provided all the needed files at https://github.com/okko/aws-cdk-esm-file-urls-reproduce for reference.

At the moment this blocks us from using NodejsFunction with a project compiling to ESM.

Pull request has been modified.

[corymhall]

An integration test would require the test tooling to compile the test case project to ESM and then synthesize that. I believe that would require a separate package.json, tsconfig.json, jest config, cdk.json that executes ts-node in esm mode, and hooking that into the way the tests run. I'm not familiar enough with the aws-cdk development tooling to do all of that, and I think that shouldn't be in the scope of this fix. I have provided all the needed files at okko/aws-cdk-esm-file-urls-reproduce for reference.

We should update the integ.esm.ts integration test as part of this PR. Right now it is just using the test/integ-handlers/esm.ts as the entry, but we should be able to add a subfolder test/integ-handlers/esm/esm.ts and add a package.json

[TheRealAmazonKendra]

Putting this back into changes requested in regard to updating the test.

[koshic]

@okko any updates? Tricks with 'entry: new URL(import.meta.url.replace(/(.*).(.+)/, $1.${id}.$2)).pathname' are so ugly.

[aws-cdk-automation]

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

Pull request has been modified.

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 21fa23e
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[TheRealAmazonKendra]

This PR has been deemed to be abandoned, and will be closed. Please create a new PR for these changes if you think this decision has been made in error.