Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds NLB TLS Listener #2122

Merged
merged 15 commits into from
Apr 26, 2019
Merged

feat: Adds NLB TLS Listener #2122

merged 15 commits into from
Apr 26, 2019

Conversation

sthulb
Copy link
Contributor

@sthulb sthulb commented Mar 29, 2019 •
edited
Loading

Adds TLS listener to NLBs based on https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-elasticloadbalancingv2-listener.html

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@sthulb sthulb requested a review from a team as a code owner March 29, 2019 21:01
@rix0rrr rix0rrr self-assigned this Apr 2, 2019
@sthulb
adds TLS termination to NLBs
cd2efea 
Adds new props to support termination:
- SSLPolicy
- Certificates
- Protocol
@sthulb
changes how protocol is defined based on feedback
7c96f48
@rix0rrr rix0rrr merged commit 71d694f into aws:master Apr 26, 2019
SanderKnape pushed a commit to SanderKnape/aws-cdk that referenced this pull request May 14, 2019
@sthulb @SanderKnape
feat(elbv2): add TLS listener for NLB (aws#2122)
06c7976 
Adds TLS termination for Network Load Balancer. Adds new props to support termination:

- SSLPolicy
- Certificates
- Protocol
This was referenced Dec 12, 2019
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sthulb @rix0rrr