revert(core): revert "fix(core): use node.path in skip bundling check for consistency with cdk deploy CLI" #21174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
corymhall
approved these changes
Jul 15, 2022
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify
bot
deleted the
revert-19950-stevehodgkiss/fix-bundling-check-to-use-same-logic-as-aws-cdk
branch
kaizencc
added a commit
that referenced
this pull request
Jul 15, 2022
… for consistency with cdk deploy CLI" (#21174) #19950 breaks users who use bundling inside a pipeline stack. Previously we converted `Stage/Stack` to `Stage-Stack` and left a comment as to why that was necessary. This comment was both insufficient and disregarded, which resulted in different behavior between the bundling logic and skip bundling logic. The asset path for skip bundling would not longer be the same as the asset path when bundling, so the asset would not be found.
comcalvi
pushed a commit
to comcalvi/aws-cdk
that referenced
this pull request
Jul 25, 2022
… for consistency with cdk deploy CLI" (aws#21174) aws#19950 breaks users who use bundling inside a pipeline stack. Previously we converted `Stage/Stack` to `Stage-Stack` and left a comment as to why that was necessary. This comment was both insufficient and disregarded, which resulted in different behavior between the bundling logic and skip bundling logic. The asset path for skip bundling would not longer be the same as the asset path when bundling, so the asset would not be found.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19950 breaks users who use bundling inside a pipeline stack. Previously we converted
Stage/StacktoStage-Stackand left a comment as to why that was necessary. This comment was both insufficient and disregarded, which resulted in different behavior between the bundling logic and skip bundling logic. The asset path for skip bundling would not longer be the same as the asset path when bundling, so the asset would not be found.