Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): present reason for cyclic references #2061

Merged
merged 7 commits into from
Mar 26, 2019

Commits on Mar 20, 2019

  1. feat(core): present reason for cyclic references

    To help people debugging cyclic references, we now trace the "reason"
    a cyclic reference got added, so that we can present the conflicting
    references instead of just presenting an error. Fix the order of
    the error message, which was the wrong way around.
    
    Clean up references a little:
    
    - Split out `Reference` and `CfnReference`, which got conflated in an
      undesirable way. `Reference` is now officially the base class for all
      references, and `CfnReference` is only one implementation of it for
      CloudFormation references.
    - Make 'scope' required for references, the only place where it was
      potentially empty was for CFN Pseudo Parameters, refactored those to
      not use classes anymore (because there's no need to).
    - Get rid of 'Ref', the class wasn't being very useful.
    - Make a dependency Construct => Stack lazy (it was conflicting at
      load time with the Stack => Construct dependency which is more
      important).
    rix0rrr committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    3d9629c View commit details
    Browse the repository at this point in the history
  2. Satisfy jsii by exporting

    rix0rrr committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    de68555 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    63cbcdf View commit details
    Browse the repository at this point in the history
  4. Another ScopedAws that I missed

    Rico Huijbers committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    04a18f4 View commit details
    Browse the repository at this point in the history
  5. And 2 more

    Rico Huijbers committed Mar 20, 2019
    Configuration menu
    Copy the full SHA
    3db479b View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2019

  1. Configuration menu
    Copy the full SHA
    ad48bcf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    b233cf9 View commit details
    Browse the repository at this point in the history