Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): add codepipeline deploy-action to ecs cluster #2049

Closed

Conversation

defel
Copy link

@defel defel commented Mar 19, 2019

This will implement #1386

No Unit-Test, one Integration Test ist present. The similar compontent s3 deploy-action has no unit-test (didnt found it), so I oriented there. Please give me feedback when required.

I have tested the integration test in my private AWS Account, and it worked.

Notes:

  • I did not implement toCodePipelineInvokeAction (on service?) as service and repository is required, as I didnt figured out an easy api for this. Need feedback if this is required.
  • The default IAM rules are maybe too open (ecs:* for *), I oriented on the default AWS CodePipeline Role: https://docs.aws.amazon.com/codepipeline/latest/userguide/how-to-custom-role.html
  • Not included in the component, but in the integration-test: sts:AssumeRole and iam:PassRole for * - same reason as point before. The following would be ideal, but I didnt figured out how to construct this with cdk:
                - Resource: "*"
                  Effect: Allow
                  Action:
                    - iam:PassRole
                  Condition:
                    StringEqualsIfExists:
                      iam:PassedToService:
                        - ec2.amazonaws.com
                        - ecs-tasks.amazonaws.com

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@defel
Copy link
Author

defel commented Mar 19, 2019

created PR under wrong account - I will close this and reopen under new PR under correct account with fixes

@defel defel closed this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants