-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda): function URLs #19817
feat(lambda): function URLs #19817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the submission! This will be an exciting feature.
Two comments/questions:
const myApiUrl = new Url(this, 'MyApiUrl', { authType: FunctionUrlAuthType.NONE });
myApiUrl.mapTo(myFn); (making some tests now with CFN to confirm this) @rix0rrr wdyt? |
Unfortunately the doc is incorrect here... VS 😢 |
@jogold Regarding the @rix0rrr @kaizen3031593 Can we please try to merge this change? |
Isn't this effectively the same as: new Url(this, 'MyApiUrl', {
authType: ...,
function: myFn,
}); ? Which you can already do? |
Yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also like to see a grantInvokeUrl
method. It should probably be both on IFunction
as well as on FunctionUrl
, so it will be wherever people think to look.
Can we also add in documentation to say what the response object of the Lambda should be? ({ statusCode, body, [headers, cookies, isBase64Encoded] }
)
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
feat(aws-lambda): Add support for function URL closes aws#19798 Refs: 1. https://docs.aws.amazon.com/lambda/latest/dg/urls-configuration.html#urls-cfn 2. https://docs.aws.amazon.com/lambda/latest/dg/API_CreateFunctionUrlConfig.html ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `cdk-integ` to deploy the infrastructure and generate the snapshot (i.e. `cdk-integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
feat(aws-lambda): Add support for function URL
closes #19798
Refs:
All Submissions:
Adding new Unconventional Dependencies:
New Features
cdk-integ
to deploy the infrastructure and generate the snapshot (i.e.cdk-integ
without--dry-run
)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license