Skip to content

feat(cloudwatch): expose dashboardName property on the L2 Dashboard construct #17721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 8 commits into from
Apr 27, 2022
Merged

feat(cloudwatch): expose dashboardName property on the L2 Dashboard construct #17721

Changes from 5 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d8e0e28
Expose DashboardName
Nov 25, 2021
fa90485
Add change requests
Nov 29, 2021
f9c0e11
Merge branch 'aws:master' into master
pedrosola Nov 30, 2021
5be251f
Merge branch 'master' into master
madeline-k Mar 23, 2022
907e7ae
Remove comment
madeline-k Mar 23, 2022
67f8834
Merge branch 'master' into master
TheRealAmazonKendra Apr 27, 2022
7179ff8
Update dashboard.ts
TheRealAmazonKendra Apr 27, 2022
77a69cd
Merge branch 'master' into master
mergify[bot] Apr 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/@aws-cdk/aws-cloudwatch/lib/dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,11 @@ export interface DashboardProps {
* A CloudWatch dashboard
*/
export class Dashboard extends Resource {
/**
* The name of this dashboard
* @attribute
Comment thread
pedrosola marked this conversation as resolved.
*/
public readonly dashboardName: string;
private readonly rows: IWidget[] = [];

constructor(scope: Construct, id: string, props: DashboardProps = {}) {
Expand All @@ -92,7 +97,7 @@ export class Dashboard extends Resource {
}
}

new CfnDashboard(this, 'Resource', {
const dashboard = new CfnDashboard(this, 'Resource', {
dashboardName: this.physicalName,
dashboardBody: Lazy.string({
produce: () => {
Expand All @@ -108,6 +113,8 @@ export class Dashboard extends Resource {
}),
});

this.dashboardName = this.getResourceNameAttribute(dashboard.ref);

(props.widgets || []).forEach(row => {
this.addWidgets(...row);
});
Expand Down