Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cognito): docs showed incorrect default value for preventUserExistenceErrors #17667

Merged
merged 2 commits into from
Nov 26, 2021
Merged

chore(cognito): docs showed incorrect default value for preventUserExistenceErrors #17667

merged 2 commits into from
Nov 26, 2021

Conversation

corymhall
Copy link
Contributor

The docs for preventUserExistenceErrors showed a default of true when
the default has always been false. Update the docs to reflect the
actual default. Also remove references to "new stacks" since the
functionality is the same between new and existing stacks.

fixes #17044


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…istenceErrors

The docs for preventUserExistenceErrors showed a default of `true` when
the default has always been `false`. Update the docs to reflect the
actual default. Also remove references to "new stacks" since the
functionality is the same between new and existing stacks.

fixes #17044
@gitpod-io
Copy link

gitpod-io bot commented Nov 23, 2021

@corymhall corymhall requested a review from a team November 23, 2021 19:13
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Nov 23, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 735d2df
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit efaaaf5 into aws:master Nov 26, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

beezly pushed a commit to beezly/aws-cdk that referenced this pull request Nov 29, 2021
…istenceErrors (aws#17667)

The docs for preventUserExistenceErrors showed a default of `true` when
the default has always been `false`. Update the docs to reflect the
actual default. Also remove references to "new stacks" since the
functionality is the same between new and existing stacks.

fixes aws#17044


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
pedrosola pushed a commit to pedrosola/aws-cdk that referenced this pull request Dec 1, 2021
…istenceErrors (aws#17667)

The docs for preventUserExistenceErrors showed a default of `true` when
the default has always been `false`. Update the docs to reflect the
actual default. Also remove references to "new stacks" since the
functionality is the same between new and existing stacks.

fixes aws#17044


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…istenceErrors (aws#17667)

The docs for preventUserExistenceErrors showed a default of `true` when
the default has always been `false`. Update the docs to reflect the
actual default. Also remove references to "new stacks" since the
functionality is the same between new and existing stacks.

fixes aws#17044


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(@aws-cdk/aws-cognito): preventUserExistenceErrors? default isn't respected
3 participants