Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ecs): undeprecate Cluster.addCapacity #17652

Merged
merged 2 commits into from
Nov 23, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion DEPRECATED_APIs.md
Original file line number Diff line number Diff line change
Expand Up @@ -751,7 +751,6 @@
| @aws-cdk/aws-ecs | BaseService.​configureAwsVpcNetworking() | use configureAwsVpcNetworkingWithSecurityGroups instead. |
| @aws-cdk/aws-ecs | BaseServiceOptions.​propagateTaskTagsFrom | Use `propagateTags` instead. |
| @aws-cdk/aws-ecs | Cluster.​addAutoScalingGroup() | Use {@link Cluster.addAsgCapacityProvider} instead. |
| @aws-cdk/aws-ecs | Cluster.​addCapacity() | Use {@link Cluster.addAsgCapacityProvider} instead. |
| @aws-cdk/aws-ecs | Cluster.​addCapacityProvider() | Use {@link enableFargateCapacityProviders} instead. |
| @aws-cdk/aws-ecs | ClusterProps.​capacityProviders | Use {@link ClusterProps.enableFargateCapacityProviders} instead. |
| @aws-cdk/aws-ecs | Ec2ServiceProps.​securityGroup | use securityGroups instead. |
Expand Down
1 change: 0 additions & 1 deletion deprecated_apis.txt
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,6 @@ constructs.Node#uniqueId
@aws-cdk/aws-ecs.BaseService#configureAwsVpcNetworking
@aws-cdk/aws-ecs.BaseServiceOptions#propagateTaskTagsFrom
@aws-cdk/aws-ecs.Cluster#addAutoScalingGroup
@aws-cdk/aws-ecs.Cluster#addCapacity
@aws-cdk/aws-ecs.Cluster#addCapacityProvider
@aws-cdk/aws-ecs.ClusterProps#capacityProviders
@aws-cdk/aws-ecs.Ec2ServiceProps#securityGroup
Expand Down
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-ecs/lib/cluster.ts
Original file line number Diff line number Diff line change
Expand Up @@ -287,11 +287,11 @@ export class Cluster extends Resource implements ICluster {
}

/**
* It is highly recommended to use {@link Cluster.addAsgCapacityProvider} instead of this method.
*
* This method adds compute capacity to a cluster by creating an AutoScalingGroup with the specified options.
*
* Returns the AutoScalingGroup so you can add autoscaling settings to it.
*
* @deprecated Use {@link Cluster.addAsgCapacityProvider} instead.
*/
public addCapacity(id: string, options: AddCapacityOptions): autoscaling.AutoScalingGroup {
// Do 2-way defaulting here: if the machineImageType is BOTTLEROCKET, pick the right AMI.
Expand Down