chore(eks): remove snapshot tests #17649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-eks
iliapolo
commented
Nov 23, 2021
| import { Cluster, KubernetesVersion, AlbController, AlbControllerVersion, HelmChart } from '../lib'; | ||
| import { testFixture } from './util'; | ||
|
|
||
| test('minimal snapshot', () => { |
Contributor
Author
There was a problem hiding this comment.
This test is basically a duplicate of the integ: https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/aws-eks/test/integ.alb-controller.ts
Not needed.
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
rix0rrr
approved these changes
Nov 23, 2021
rix0rrr
pushed a commit
that referenced
this pull request
Nov 23, 2021
rix0rrr
pushed a commit
that referenced
this pull request
Nov 23, 2021
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary snapshot tests, which are failing #17644.
Still investigating why would they fail.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license