Skip to content

chore(generate-missing-examples): types in subodules not included #17614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Nov 21, 2021
Merged

chore(generate-missing-examples): types in subodules not included #17614

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6ea75e
chore(generate-missing-examples): fix - submodules were not taken int…
Nov 21, 2021
763405c
rewrite
Nov 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tools/@aws-cdk/generate-examples/lib/generate-missing-examples.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/* eslint-disable no-console */
import { promises as fs } from 'fs';
import { Assembly, TypeSystem } from 'jsii-reflect';
import { Assembly, ClassType, InterfaceType, TypeSystem } from 'jsii-reflect';

// This import should come from @jsii/spec. Replace when that is possible.
import { LanguageTablet, RosettaTranslator, SnippetLocation, SnippetParameters, TypeScriptSnippet, typeScriptSnippetFromCompleteSource } from 'jsii-rosetta';
Expand Down Expand Up @@ -33,10 +33,11 @@ export async function generateMissingExamples(assemblyLocations: string[], optio

const snippets = loadedAssemblies.flatMap(({ assembly }) => {
// Classes and structs
const documentableTypes = [
...assembly.classes.filter(c => !c.docs.example),
...assembly.interfaces.filter(i => !i.docs.example && i.datatype),
];
const documentableTypes: Array<ClassType | InterfaceType> = [];
for (const m of [assembly, ...assembly.allSubmodules]) {
documentableTypes.push(...m.classes.filter(c => !c.docs.example));
documentableTypes.push(...m.interfaces.filter(c => !c.docs.example && c.datatype));
}

console.log(`${assembly.name}: ${documentableTypes.length} classes to document`);
if (documentableTypes.length === 0) { return []; }
Expand Down