Skip to content

Conversation

@markussiebert
Copy link
Contributor

@markussiebert markussiebert commented Nov 19, 2021

fixes: #17605

Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if docker is installed... Ok
Checking if docker is running... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Ok
Checking if python3 is installed... Ok
Checking python3 version... Ok

and everything seems to build fine

Think fixes to test files are unnecessary, and don't know what to document for this...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Nov 19, 2021

@markussiebert markussiebert changed the title fix: dotnet 6 supported fix: dotnet 6 support for building cdk Nov 20, 2021
@markussiebert
Copy link
Contributor Author

@iliapolo maybe you can review this? I think it's a small change and won't do anything bad

@iliapolo
Copy link
Contributor

@iliapolo maybe you can review this? I think it's a small change and won't do anything bad

@markussiebert famous last words 😄

It looks OK to me but i'll poke @RomainMuller for a second opinion here.

@rix0rrr rix0rrr changed the title fix: dotnet 6 support for building cdk chore: dotnet 6 support for building cdk Nov 22, 2021
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll ship it, I'm feeling brave ;)

@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 3cca4a6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2b34abb into aws:master Nov 22, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@markussiebert markussiebert deleted the feature/fixdotnet6 branch November 25, 2021 07:55
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
fixes: aws#17605 
```bash
Checking if node is installed... Ok
Checking node version... Ok
Checking if yarn is installed... Ok
Checking yarn version... Ok
Checking if docker is installed... Ok
Checking if docker is running... Ok
Checking if dotnet is installed... Ok
Checking dotnet version... Ok
Checking if python3 is installed... Ok
Checking python3 version... Ok
```

and everything seems to build fine

Think fixes to test files are unnecessary, and don't know what to document for this...

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(build.sh): dotnet 6.x.x not supported by check-build-prerequisites.sh

4 participants