-
Notifications
You must be signed in to change notification settings - Fork 4.4k
chore: dotnet 6 support for building cdk #17606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@iliapolo maybe you can review this? I think it's a small change and won't do anything bad |
@markussiebert famous last words 😄 It looks OK to me but i'll poke @RomainMuller for a second opinion here. |
rix0rrr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll ship it, I'm feeling brave ;)
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fixes: aws#17605 ```bash Checking if node is installed... Ok Checking node version... Ok Checking if yarn is installed... Ok Checking yarn version... Ok Checking if docker is installed... Ok Checking if docker is running... Ok Checking if dotnet is installed... Ok Checking dotnet version... Ok Checking if python3 is installed... Ok Checking python3 version... Ok ``` and everything seems to build fine Think fixes to test files are unnecessary, and don't know what to document for this... *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes: #17605
and everything seems to build fine
Think fixes to test files are unnecessary, and don't know what to document for this...
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license