Skip to content

fix(cli): skip bundling for the 'watch' command #17455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Nov 10, 2021
Merged

fix(cli): skip bundling for the 'watch' command #17455

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b4b2cd
fix(core): bundling skipped with watch
jogold Nov 10, 2021
84156c5
Merge branch 'master' into watch-bundling-command
mergify[bot] Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/aws-cdk/lib/settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@ export enum Command {
METADATA = 'metadata',
INIT = 'init',
VERSION = 'version',
WATCH = 'watch',
}

const BUNDLING_COMMANDS = [
Command.DEPLOY,
Command.DIFF,
Command.SYNTH,
Command.SYNTHESIZE,
Command.WATCH,
];

export type Arguments = {
Expand Down Expand Up @@ -251,7 +253,7 @@ export class Settings {
// Determine bundling stacks
let bundlingStacks: string[];
if (BUNDLING_COMMANDS.includes(argv._[0])) {
// If we deploy, diff or synth a list of stacks exclusively we skip
// If we deploy, diff, synth or watch a list of stacks exclusively we skip
// bundling for all other stacks.
bundlingStacks = argv.exclusively
? argv.STACKS ?? ['*']
Expand Down
22 changes: 22 additions & 0 deletions packages/aws-cdk/test/settings.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,16 @@ test('bundling stacks defaults to * for deploy', () => {
expect(settings.get(['bundlingStacks'])).toEqual(['*']);
});

test('bundling stacks defaults to * for watch', () => {
// GIVEN
const settings = Settings.fromCommandLineArguments({
_: [Command.WATCH],
});

// THEN
expect(settings.get(['bundlingStacks'])).toEqual(['*']);
});

test('bundling stacks with deploy exclusively', () => {
// GIVEN
const settings = Settings.fromCommandLineArguments({
Expand All @@ -112,6 +122,18 @@ test('bundling stacks with deploy exclusively', () => {
expect(settings.get(['bundlingStacks'])).toEqual(['cool-stack']);
});

test('bundling stacks with watch exclusively', () => {
// GIVEN
const settings = Settings.fromCommandLineArguments({
_: [Command.WATCH],
exclusively: true,
STACKS: ['cool-stack'],
});

// THEN
expect(settings.get(['bundlingStacks'])).toEqual(['cool-stack']);
});

test('should include outputs-file in settings', () => {
// GIVEN
const settings = Settings.fromCommandLineArguments({
Expand Down