Skip to content

chore(ubergen): make rosetta fixtures submodule aware #17438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 3 commits into from
Nov 10, 2021
Merged

chore(ubergen): make rosetta fixtures submodule aware #17438

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
761f43e
make rosetta fixtures submodule aware
kaizencc Nov 9, 2021
cd19e96
special case for core
kaizencc Nov 10, 2021
1b2a9d4
Merge branch 'master' into ubergen
mergify[bot] Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/@aws-cdk/ubergen/bin/ubergen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,8 +254,9 @@ async function combineRosettaFixtures(libraries: readonly LibraryReference[]) {

for (const library of libraries) {
const packageRosettaDir = path.join(library.root, 'rosetta');
const uberRosettaTargetDir = library.shortName === 'core' ? uberRosettaDir : path.join(uberRosettaDir, library.shortName.replace(/-/g, '_'));
if (await fs.pathExists(packageRosettaDir)) {
await fs.copy(packageRosettaDir, uberRosettaDir, {
await fs.copy(packageRosettaDir, uberRosettaTargetDir, {
Copy link
Contributor

@rix0rrr rix0rrr Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to make an exception for the core submodule, which gets moved to the ROOT of the monopackage, not placed in a submodule.

Copy link
Contributor Author

@kaizencc kaizencc Nov 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now the fixtures show up in the rosetta directory and the number of outstanding failures went from 1973 to 1722. Also validated that stack.AddTransform compiles along with a few other examples from the core module.

overwrite: true,
recursive: true,
});
Expand Down