Skip to content

Conversation

@kaizencc
Copy link
Contributor

@kaizencc kaizencc commented Nov 8, 2021

Included in this PR:

  • chore(stepfunctions): migrate tests to assertions
  • chore(stepfunctions-tasks): migrate tests to assertions

For both modules, removes dev dependency to assert-internal and replaces it with assertions.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@kaizencc kaizencc requested a review from nija-at November 8, 2021 18:00
@gitpod-io
Copy link

gitpod-io bot commented Nov 8, 2021

@github-actions github-actions bot added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Nov 8, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 653a202
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d75431b into aws:master Nov 9, 2021
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaizencc kaizencc deleted the sfn-assertions branch November 10, 2021 13:25
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
Included in this PR:
- chore(stepfunctions): migrate tests to assertions
- chore(stepfunctions-tasks): migrate tests to assertions

For both modules, removes dev dependency to `assert-internal` and replaces it with `assertions`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-stepfunctions Related to AWS StepFunctions contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants