fix(NestedStack): add asset metadata to NestedStack resources for local tooling #17343
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-cloudformation
mildaniel
changed the title
rix0rrr
left a comment
rix0rrr
left a comment
There was a problem hiding this comment.
The unit test is good enough for me.
I don't enjoy the added complexity added to the integ tools, just to update integration tests in the aws-cloudformation package which is deprecated and might be removed at any point in time anyway (which would remove those tests and the point of those changes).
Remove those and leave the unit test please? Then happy to ship.
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…al tooling (aws#17343) ---- Reference issue aws#14593 Building on this initial PR: aws#1433 We're looking to add asset metadata to the NestedStack resource. The implementation is similar to this one [design/code-asset-metadata.md](https://github.com/aws/aws-cdk/pull/design/code-asset-metadata.md). This will allow SAM CLI to support CDK-synthed templates nested function resources. *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
3 participants
Reference issue #14593
Building on this initial PR: #1433
We're looking to add asset metadata to the NestedStack resource. The implementation is similar to this one design/code-asset-metadata.md. This will allow SAM CLI to support CDK-synthed templates nested function resources.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license