feat(stepfunctions-tasks): add AutoTerminationPolicy to EmrCreateCluster
#16976
Conversation
…o EmrCreateCluster step
|
|
peterwoodworth
changed the title
There was a problem hiding this comment.
Regarding the comment below, this does not seem like it is possible to do in the CDK. The CDK generates a template that gets consumed by CloudFormation to provision resources, so if the property is not in the CloudFormation it is not something we can do.
Have you tested your code in an integration test? I have a feeling that the AutoTerminationPolicy, though it shows up in the template (and thus your test passes), does not actually do anything come deploy time.
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/private/cluster-utils.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-stepfunctions-tasks/lib/emr/emr-create-cluster.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: kaizen3031593 <[email protected]>
Co-authored-by: kaizen3031593 <[email protected]>
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
…ter-utils.ts Co-authored-by: kaizen3031593 <[email protected]>
…luster.ts Co-authored-by: kaizen3031593 <[email protected]>
…luster.ts Co-authored-by: kaizen3031593 <[email protected]>
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
kaizencc
changed the title
AutoTerminationPolicy to EmrCreateCluster
|
@jacobfi to merge this, we need to get past this error: The merge-queue pull request can't be update
Details: `Pull request can't be updated with latest base branch changes
Mergify needs the author permission to update the base branch of the pull request.
audienceproject needs to authorize modification on its head branch.
err-code: C1535` |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for approving the PR. I would love to give your mergify bot access to the fork, but I can't seem to make it work. I have followed the link to the Github doc explaining how, but the option of "Allow edits from maintainers" is nowhere to be seen on this PR. I can add people and teams manually to access the fork, but I don't know which users/teams to add. Can you help with that? |
|
@kaizen3031593 |
|
@jacobfi unfortunately that doesn't help. We really need that "allow edits from maintainers" tag to be set. I can think of two things to do: perhaps somewhere in your settings you have set something to never allow this option? Alternatively you can try to open a new pull request and there should be a button that says "allow edits from maintainers" that is by default set to true. See if that's the case for you, and if so, you can just open a new PR with that tag already set. |
|
Hello @kaizen3031593 |
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This reverts commit: #16976. `AutoTerminationPolicy` was never supported by stepfunctions, even though it is supported by EMR. This was not discovered until it was used since the documentation does not mention this limitation of stepfunctions. Since it never worked, we are okay with the breaking change here. Closes #17452.
…luster` (aws#16976) Auto-termination is supported with Amazon EMR versions 5.30.0 and 6.1.0 and later. This change enables CDK users to specify an auto-termination policy on EMR clusters created through the aws-stepfunctions task EmrCreateCluster. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This reverts commit: aws#16976. `AutoTerminationPolicy` was never supported by stepfunctions, even though it is supported by EMR. This was not discovered until it was used since the documentation does not mention this limitation of stepfunctions. Since it never worked, we are okay with the breaking change here. Closes aws#17452.
Auto-termination is supported with Amazon EMR versions 5.30.0 and 6.1.0 and later.
This change enables CDK users to specify an auto-termination policy on EMR clusters created through the aws-stepfunctions task EmrCreateCluster.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license